[Autodiscover] Handle input-not-finished errors in config reload #20915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chrismark <chrismarkou92@gmail.com>
ChrsMark
added
bug
needs_backport
botelastic
bot
added
the
needs_team
Signed-off-by: chrismark <chrismarkou92@gmail.com>
ChrsMark
added
[zube]: In Review
review
Team:Platforms
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
botelastic
bot
removed
the
needs_team
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
jsoriano
approved these changes
Sep 2, 2020
jsoriano
approved these changes
Sep 2, 2020
ChrsMark
added a commit
to ChrsMark/beats
that referenced
this pull request
Sep 2, 2020
…stic#20915) (cherry picked from commit 35e6b60)
ChrsMark
removed
the
needs_backport
ChrsMark
added a commit
that referenced
this pull request
Sep 3, 2020
…rrors in config reload (#20928)
v1v
added a commit
to v1v/beats
that referenced
this pull request
Sep 3, 2020
…ne-2.0 * upstream/master: [Metricbeat][test] Disable ec2 flaky test (elastic#20959) Check if tracer is active before starting a transaction (elastic#20852) [Elastic Agent] Add support for variable replacement from providers (elastic#20839) Only request wildcard expansion for hidden indices if supported (elastic#20938) [Ingest Manager] New agent structure (symlinks) (elastic#20400) [Ingest Manager] Print a message confirming shutdown (elastic#20948) Skip flaky test on unix input (elastic#20942) [Ingest Manager] Align introspect-inspect naming in code (elastic#20952) [Filebeat][zeek] Map new x509 fields for ssl module (elastic#20927) [CI] fix regression with variable name (elastic#20930) [Autodiscover] Handle input-not-finished errors in config reload (elastic#20915) [Ingest Manager] Remove Success from fleet contract (elastic#20449)
|
@ChrsMark I am confused by this change. I just ended up with this problem: 2020-09-24T13:04:39.398Z ERROR [autodiscover] cfgfile/list.go:96 Error creating runner from config: Can only start an input when all related states are finished: {Id:2069814-64771 Finished:false Fileinfo:0xc42018c340 Source:/var/log/containers/serverr-57cd7746ff-pzzlg_default_server-e48194c34dcac07db908e93c44ae34d5130a28ae79766b7645ff3686ff66ef4d.log Offset:12941 Timestamp:2020-09-24 13:04:38.095112478 +0000 UTC m=+1743.843569158 TTL:-1ns Type:log Meta:map[] FileStateOS:2069814-64771}I have no idea what this means, but at least I glad that as a user I could run
|
Hi! First of all this "error" is sth that has to do with the state of files that are being harvested. It should go away once the harvesting is completed and Autodiscover will be able to start the input again. So imagine that this error could be ignored. This is the reason we turned this error from ERROR level to DEBUG level. This change will be landed with |
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds special error handling in config reload flow to handle state errors specially by not logging in ERROR level to avoid confusion in logging.
Current state:
Patch:
Why is it important?
To avoid confusion in logging because of a non actual ERROR is logged as an ERROR. We need to log with lower severity this kind of errors.
How to test this PR locally
Using testing steps from #20305.
Related issues