Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #20449 to 7.x: Remove Success from fleet contract #20947

Merged
merged 1 commit into from
Sep 7, 2020
Merged

Cherry-pick #20449 to 7.x: Remove Success from fleet contract #20947

merged 1 commit into from
Sep 7, 2020

Conversation

michalpristas
Copy link
Contributor

Cherry-pick of PR #20449 to 7.x branch. Original message:

What does this PR do?

Based on #20288 this PR removes Success field from request/response in calls between agent and fleet.
Fleet side work here: elastic/kibana#73223

Why is it important?

#20288

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Fixes: #20288

@michalpristas michalpristas self-assigned this Sep 3, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 3, 2020
@elasticmachine
Copy link
Collaborator

💔 Tests Failed

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20947 opened]

  • Start Time: 2020-09-03T05:46:32.576+0000

  • Duration: 91 min 57 sec

Test stats 🧪

Test Results
Failed 1
Passed 1576
Skipped 3
Total 1580

Test errors

Expand to view the tests failures

  • Name: Build and Test / Elastic Agent Mac OS X / TestConfigurableService – operation

    • Age: 1
    • Duration: 0
    • Error Details: Failed

Steps errors

Expand to view the steps failures

  • Name: Mage build unitTest

    • Description: mage build unitTest

    • Duration: 65 min 43 sec

    • Start Time: 2020-09-03T06:11:37.830+0000

    • log

  • Name: Recursively delete the current directory from the workspace

    • Description: script returned exit code 1

    • Duration: 0 min 9 sec

    • Start Time: 2020-09-03T07:16:29.585+0000

    • log

Log output

Expand to view the last 100 lines of log output 

[2020-09-03T07:16:20.683Z]   Coverage Report: /private/var/lib/jenkins/workspace/Beats_beats_PR-20947/src/github.com/elastic/beats/x-pack/elastic-agent/build/TEST-go-unit.html
[2020-09-03T07:16:20.683Z]   JUnit Report:    /private/var/lib/jenkins/workspace/Beats_beats_PR-20947/src/github.com/elastic/beats/x-pack/elastic-agent/build/TEST-go-unit.xml
[2020-09-03T07:16:20.683Z]   Output File:     /private/var/lib/jenkins/workspace/Beats_beats_PR-20947/src/github.com/elastic/beats/x-pack/elastic-agent/build/TEST-go-unit.out
[2020-09-03T07:16:20.683Z] >> go test: Unit Test Failed
[2020-09-03T07:16:20.683Z] Error: go test failed: 1 test failures
[2020-09-03T07:16:22.032Z] Docker machine "default" does not exist. Use "docker-machine ls" to list machines. Use "docker-machine create" to add a new one.
[2020-09-03T07:16:22.032Z] Docker machine "default" does not exist. Use "docker-machine ls" to list machines. Use "docker-machine create" to add a new one.
[2020-09-03T07:16:22.032Z] Client:
[2020-09-03T07:16:22.032Z]  Version:           18.06.1-ce
[2020-09-03T07:16:22.032Z]  API version:       1.38
[2020-09-03T07:16:22.032Z]  Go version:        go1.10.3
[2020-09-03T07:16:22.032Z]  Git commit:        e68fc7a
[2020-09-03T07:16:22.032Z]  Built:             Tue Aug 21 17:21:31 2018
[2020-09-03T07:16:22.032Z]  OS/Arch:           darwin/amd64
[2020-09-03T07:16:22.032Z]  Experimental:      false
[2020-09-03T07:16:22.032Z] Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
[2020-09-03T07:16:22.032Z] It requires Docker daemon to be installed and running
[2020-09-03T07:16:23.045Z] + python .ci/scripts/pre_archive_test.py
[2020-09-03T07:16:23.222Z] Copy ./x-pack/elastic-agent/build into build/x-pack/elastic-agent/build
[2020-09-03T07:16:23.238Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20947/src/github.com/elastic/beats/build
[2020-09-03T07:16:23.350Z] Recording test results
[2020-09-03T07:16:23.800Z] Stashed 1 file(s)
[2020-09-03T07:16:23.879Z] Archiving artifacts
[2020-09-03T07:16:25.070Z] + python .ci/scripts/search_system_tests.py
[2020-09-03T07:16:25.326Z] [INFO] system-tests=''. If no empty then let's create a tarball
[2020-09-03T07:16:26.708Z] Post stage
[2020-09-03T07:16:26.727Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20947/src/github.com/elastic/beats
[2020-09-03T07:16:27.701Z] Starting "default"...
[2020-09-03T07:16:27.702Z] Machine "default" is already running.
[2020-09-03T07:16:29.322Z] Error checking TLS connection: Error checking and/or regenerating the certs: There was an error validating certificates for host "192.168.99.102:2376": dial tcp 192.168.99.102:2376: connect: connection refused
[2020-09-03T07:16:29.322Z] You can attempt to regenerate them using 'docker-machine regenerate-certs [name]'.
[2020-09-03T07:16:29.322Z] Be advised that this will trigger a Docker daemon restart which might stop running containers.
[2020-09-03T07:16:29.322Z] 
[2020-09-03T07:16:29.322Z] Client:
[2020-09-03T07:16:29.322Z]  Version:           18.06.1-ce
[2020-09-03T07:16:29.322Z]  API version:       1.38
[2020-09-03T07:16:29.322Z]  Go version:        go1.10.3
[2020-09-03T07:16:29.322Z]  Git commit:        e68fc7a
[2020-09-03T07:16:29.322Z]  Built:             Tue Aug 21 17:21:31 2018
[2020-09-03T07:16:29.322Z]  OS/Arch:           darwin/amd64
[2020-09-03T07:16:29.322Z]  Experimental:      false
[2020-09-03T07:16:29.322Z] Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
[2020-09-03T07:16:29.322Z] It requires Docker daemon to be installed and running
[2020-09-03T07:16:38.664Z] Failed in branch Elastic Agent Mac OS X
[2020-09-03T07:16:48.646Z] [INFO] unstashV2: JOB_GCS_BUCKET is set. bucket param got precedency instead.
[2020-09-03T07:16:48.687Z] [INFO] unstashV2: JOB_GCS_CREDENTIALS is set. credentialsId param got precedency instead.
[2020-09-03T07:16:48.789Z] [Google Cloud Storage Plugin] Found 1 files to download from pattern: gs://beats-ci-temp/Beats/beats/PR-20947-1/source/source.tgz
[2020-09-03T07:16:48.816Z] [Google Cloud Storage Plugin] Downloading: Beats/beats/PR-20947-1/source/source.tgz to local path: /var/lib/jenkins/workspace/Beats_beats_PR-20947/source.tgz
[2020-09-03T07:16:56.464Z] + tar --version
[2020-09-03T07:16:56.785Z] + tar -xpf source.tgz
[2020-09-03T07:17:07.155Z] + rm source.tgz
[2020-09-03T07:17:07.436Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20947/src/github.com/elastic/beats
[2020-09-03T07:17:07.485Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20947/src/github.com/elastic/beats/Lint
[2020-09-03T07:17:07.651Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20947/src/github.com/elastic/beats/Elastic-Agent-x-pack
[2020-09-03T07:17:07.815Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20947/src/github.com/elastic/beats/Elastic-Agent-x-pack-Windows
[2020-09-03T07:17:07.977Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20947/src/github.com/elastic/beats/Elastic-Agent-Mac-OS-X
[2020-09-03T07:17:08.516Z] + cat
[2020-09-03T07:17:08.516Z] + /usr/local/bin/runbld ./runbld-script --job-name elastic+beats+pull-request
[2020-09-03T07:17:08.516Z] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
[2020-09-03T07:17:15.107Z] runbld>>> runbld started
[2020-09-03T07:17:15.107Z] runbld>>> 1.6.12/f45d832f2ba0aa2722ab4ec1fda8ad140f027f8b
[2020-09-03T07:17:17.033Z] runbld>>> The following profiles matched the job 'elastic+beats+pull-request' in order of occurrence in the config (last value wins).
[2020-09-03T07:17:17.033Z] runbld>>> Matches in the system config:
[2020-09-03T07:17:17.033Z] runbld>>> - Matched ^elastic\+beats
[2020-09-03T07:17:17.033Z] runbld>>> - Matched ^elastic\+beats\+pull-request
[2020-09-03T07:17:17.973Z] runbld>>> Debug logging enabled.
[2020-09-03T07:17:17.973Z] runbld>>> Storing result
[2020-09-03T07:17:18.234Z] runbld>>> Store result: created {:total 2, :successful 2, :failed 0} 1
[2020-09-03T07:17:18.234Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1597739501209/t/20200903071717-4DB16035
[2020-09-03T07:17:18.234Z] runbld>>> Adding system facts.
[2020-09-03T07:17:19.181Z] runbld>>> Adding vcs info for the latest commit:  72e4396f460565504e30cff8e74c231e8e12afbe
[2020-09-03T07:17:19.181Z] runbld>>> >>>>>>>>>>>> SCRIPT EXECUTION BEGIN >>>>>>>>>>>>
[2020-09-03T07:17:19.181Z] runbld>>> Adding /usr/lib/jvm/java-8-openjdk-amd64/bin to the path.
[2020-09-03T07:17:19.181Z] Processing JUnit reports with runbld...
[2020-09-03T07:17:19.181Z] + echo 'Processing JUnit reports with runbld...'
[2020-09-03T07:17:19.753Z] runbld>>> <<<<<<<<<<<< SCRIPT EXECUTION END <<<<<<<<<<<<
[2020-09-03T07:17:19.753Z] runbld>>> DURATION: 25ms
[2020-09-03T07:17:19.753Z] runbld>>> STDOUT: 40 bytes
[2020-09-03T07:17:19.753Z] runbld>>> STDERR: 49 bytes
[2020-09-03T07:17:19.753Z] runbld>>> WRAPPED PROCESS: SUCCESS (0)
[2020-09-03T07:17:19.753Z] runbld>>> Searching for build metadata in /var/lib/jenkins/workspace/Beats_beats_PR-20947
[2020-09-03T07:17:20.694Z] runbld>>> Storing build metadata: 
[2020-09-03T07:17:20.694Z] runbld>>> Adding test report.
[2020-09-03T07:17:20.694Z] runbld>>> Searching for junit test output files with the pattern: TEST-.*\.xml$ in: /var/lib/jenkins/workspace/Beats_beats_PR-20947/src/github.com/elastic/beats
[2020-09-03T07:17:21.264Z] runbld>>> Found 3 test output files
[2020-09-03T07:17:21.836Z] runbld>>> Test output logs contained: Errors: 0 Failures: 1 Tests: 1580 Skipped: 0
[2020-09-03T07:17:21.836Z] runbld>>> Storing result
[2020-09-03T07:17:21.836Z] runbld>>> FAILURES: 1
[2020-09-03T07:17:22.407Z] runbld>>> Store result: updated {:total 2, :successful 2, :failed 0} 2
[2020-09-03T07:17:22.407Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1597739501209/t/20200903071717-4DB16035
[2020-09-03T07:17:22.669Z] runbld>>> Email notification disabled by environment variable.
[2020-09-03T07:17:22.669Z] runbld>>> Slack notification disabled by environment variable.
[2020-09-03T07:17:28.673Z] Running on Jenkins in /var/lib/jenkins/workspace/Beats_beats_PR-20947
[2020-09-03T07:17:29.050Z] [INFO] getVaultSecret: Getting secrets
[2020-09-03T07:17:29.149Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-09-03T07:17:30.326Z] + chmod 755 generate-build-data.sh
[2020-09-03T07:17:30.326Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20947/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20947/runs/1 FAILURE 5457475
[2020-09-03T07:17:30.326Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20947/runs/1/steps/?limit=10000 -o steps-info.json
[2020-09-03T07:17:31.237Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20947/runs/1/tests/?status=FAILED -o tests-errors.json
[2020-09-03T07:17:31.237Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20947/runs/1/log/ -o pipeline-log.txt

blakerouse
blakerouse approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks good.

@michalpristas michalpristas merged commit 39994b0 into elastic:7.x Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakerouse blakerouse blakerouse approved these changes

Assignees

@michalpristas michalpristas

Labels
backport enhancement review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michalpristas @elasticmachine @blakerouse