Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #20948 to 7.x: Print a message confirming shutdown #20957

Merged
merged 1 commit into from
Sep 4, 2020

Conversation

michalpristas
Copy link
Contributor

Cherry-pick of PR #20948 to 7.x branch. Original message:

What does this PR do?

Currently, when you exit the Elastic Agent it takes several seconds to close the app. The user may be left wondering if its frozen or crashed. It'd be better to print a line to stdout and to the logfile confirming the shutdown is in progress and what needs to happen before the application exits.

Why is it important?

Fixes: #20578

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 3, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20957 opened]

  • Start Time: 2020-09-03T11:10:35.481+0000

  • Duration: 34 min 30 sec

Test stats 🧪

Test Results
Failed 0
Passed 1577
Skipped 3
Total 1580

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks good.

@michalpristas michalpristas merged commit edcd5cb into elastic:7.x Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants