Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update apm agent #21031

Merged
merged 2 commits into from
Sep 9, 2020
Merged

Update apm agent #21031

merged 2 commits into from
Sep 9, 2020

Conversation

jalvz
Copy link
Contributor

@jalvz jalvz commented Sep 9, 2020

What does this PR do?

Updates the Go agent to bring in elastic/apm-agent-go#816
That change ensures that a go-routine closes before existing. It is not a problematic issue in real environments, but it might make the GoroutineChecker intermittently unhappy on CI, so this fixes it.

Why is it important?

To have agent not interfere with output/pipeline tests in Beats.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 9, 2020
@jalvz jalvz added the Team:apm APM Server team issues/PRs label Sep 9, 2020
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 9, 2020
@jalvz jalvz added needs_team Indicates that the issue/PR needs a Team:* label Team:Integrations Label for the Integrations team labels Sep 9, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 9, 2020
@botelastic
Copy link

botelastic bot commented Sep 9, 2020

This pull request doesn't have a Team:<team> label.

@jalvz jalvz requested a review from jsoriano September 9, 2020 07:25
@elasticmachine
Copy link
Collaborator

💔 Build Failed

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21031 opened]

  • Start Time: 2020-09-09T07:25:53.852+0000

  • Duration: 23 min 8 sec

Steps errors

Expand to view the steps failures

  • Name: Make check
    • Description: make check

    • Duration: 15 min 16 sec

    • Start Time: 2020-09-09T07:32:36.805+0000

    • log

Log output

Expand to view the last 100 lines of log output

[2020-09-09T07:48:08.080Z] Failed in branch Elastic Agent x-pack Windows
[2020-09-09T07:48:08.093Z] Failed in branch Elastic Agent Mac OS X
[2020-09-09T07:48:08.105Z] Failed in branch Filebeat oss
[2020-09-09T07:48:08.116Z] Failed in branch Filebeat x-pack
[2020-09-09T07:48:08.129Z] Failed in branch Filebeat Mac OS X
[2020-09-09T07:48:08.142Z] Failed in branch Filebeat x-pack Mac OS X
[2020-09-09T07:48:08.152Z] Failed in branch Filebeat Windows
[2020-09-09T07:48:08.164Z] Failed in branch Filebeat x-pack Windows
[2020-09-09T07:48:08.177Z] Failed in branch Heartbeat oss
[2020-09-09T07:48:08.187Z] Failed in branch Heartbeat Mac OS X
[2020-09-09T07:48:08.207Z] Failed in branch Heartbeat Windows
[2020-09-09T07:48:08.217Z] Failed in branch Auditbeat oss Linux
[2020-09-09T07:48:08.229Z] Failed in branch Auditbeat crosscompile
[2020-09-09T07:48:08.248Z] Failed in branch Auditbeat oss Mac OS X
[2020-09-09T07:48:08.260Z] Failed in branch Auditbeat oss Windows
[2020-09-09T07:48:08.269Z] Failed in branch Auditbeat x-pack
[2020-09-09T07:48:08.279Z] Failed in branch Auditbeat x-pack Mac OS X
[2020-09-09T07:48:08.289Z] Failed in branch Auditbeat x-pack Windows
[2020-09-09T07:48:08.302Z] Failed in branch Libbeat x-pack
[2020-09-09T07:48:08.312Z] Failed in branch Metricbeat OSS Unit tests
[2020-09-09T07:48:08.324Z] Failed in branch Metricbeat OSS Go Integration tests
[2020-09-09T07:48:08.337Z] Failed in branch Metricbeat OSS Python Integration tests
[2020-09-09T07:48:08.349Z] Failed in branch Metricbeat crosscompile
[2020-09-09T07:48:08.367Z] Failed in branch Metricbeat Mac OS X
[2020-09-09T07:48:08.380Z] Failed in branch Metricbeat x-pack Mac OS X
[2020-09-09T07:48:08.396Z] Failed in branch Metricbeat Windows
[2020-09-09T07:48:08.406Z] Failed in branch Metricbeat x-pack Windows
[2020-09-09T07:48:08.422Z] Failed in branch Packetbeat Linux
[2020-09-09T07:48:08.432Z] Failed in branch Packetbeat Mac OS X
[2020-09-09T07:48:08.452Z] Failed in branch Packetbeat Windows
[2020-09-09T07:48:08.463Z] Failed in branch dockerlogbeat
[2020-09-09T07:48:08.479Z] Failed in branch Winlogbeat oss
[2020-09-09T07:48:08.491Z] Failed in branch Winlogbeat Windows
[2020-09-09T07:48:08.504Z] Failed in branch Winlogbeat Windows x-pack
[2020-09-09T07:48:08.518Z] Failed in branch Functionbeat x-pack
[2020-09-09T07:48:08.529Z] Failed in branch Functionbeat Mac OS X x-pack
[2020-09-09T07:48:08.544Z] Failed in branch Functionbeat Windows
[2020-09-09T07:48:08.556Z] Failed in branch Journalbeat
[2020-09-09T07:48:08.566Z] Failed in branch Generators Metricbeat Mac OS X
[2020-09-09T07:48:08.577Z] Failed in branch Generators Beat Mac OS X
[2020-09-09T07:48:08.589Z] Failed in branch Kubernetes
[2020-09-09T07:48:09.022Z] Stage "Libbeat" skipped due to earlier failure(s)
[2020-09-09T07:48:09.038Z] Stage "Metricbeat x-pack" skipped due to earlier failure(s)
[2020-09-09T07:48:09.053Z] Stage "Generators" skipped due to earlier failure(s)
[2020-09-09T07:48:10.205Z] Failed in branch Metricbeat x-pack
[2020-09-09T07:48:10.216Z] Failed in branch Generators
[2020-09-09T07:48:10.304Z] Stage "Libbeat" skipped due to earlier failure(s)
[2020-09-09T07:48:10.576Z] Failed in branch Libbeat
[2020-09-09T07:48:20.824Z] [INFO] unstashV2: JOB_GCS_BUCKET is set. bucket param got precedency instead.
[2020-09-09T07:48:20.870Z] [INFO] unstashV2: JOB_GCS_CREDENTIALS is set. credentialsId param got precedency instead.
[2020-09-09T07:48:20.962Z] [Google Cloud Storage Plugin] Found 1 files to download from pattern: gs://beats-ci-temp/Beats/beats/PR-21031-1/source/source.tgz
[2020-09-09T07:48:20.990Z] [Google Cloud Storage Plugin] Downloading: Beats/beats/PR-21031-1/source/source.tgz to local path: /var/lib/jenkins/workspace/Beats_beats_PR-21031/source.tgz
[2020-09-09T07:48:30.967Z] + tar --version
[2020-09-09T07:48:31.287Z] + tar -xpf source.tgz
[2020-09-09T07:48:41.658Z] + rm source.tgz
[2020-09-09T07:48:41.687Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-21031/src/github.com/elastic/beats
[2020-09-09T07:48:41.744Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-21031/src/github.com/elastic/beats/Lint
[2020-09-09T07:48:42.334Z] + cat
[2020-09-09T07:48:42.334Z] + /usr/local/bin/runbld ./runbld-script --job-name elastic+beats+pull-request
[2020-09-09T07:48:42.334Z] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
[2020-09-09T07:48:48.933Z] runbld>>> runbld started
[2020-09-09T07:48:48.933Z] runbld>>> 1.6.12/f45d832f2ba0aa2722ab4ec1fda8ad140f027f8b
[2020-09-09T07:48:49.915Z] runbld>>> The following profiles matched the job 'elastic+beats+pull-request' in order of occurrence in the config (last value wins).
[2020-09-09T07:48:49.915Z] runbld>>> Matches in the system config:
[2020-09-09T07:48:49.915Z] runbld>>> - Matched ^elastic\+beats
[2020-09-09T07:48:49.915Z] runbld>>> - Matched ^elastic\+beats\+pull-request
[2020-09-09T07:48:51.306Z] runbld>>> Debug logging enabled.
[2020-09-09T07:48:51.306Z] runbld>>> Storing result
[2020-09-09T07:48:51.566Z] runbld>>> Store result: created {:total 2, :successful 2, :failed 0} 1
[2020-09-09T07:48:51.566Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1597739501209/t/20200909074851-8BF259B4
[2020-09-09T07:48:51.566Z] runbld>>> Adding system facts.
[2020-09-09T07:48:52.520Z] runbld>>> Adding vcs info for the latest commit:  405daf51809ce846fd56a14afb6695ddb74083ae
[2020-09-09T07:48:52.520Z] runbld>>> >>>>>>>>>>>> SCRIPT EXECUTION BEGIN >>>>>>>>>>>>
[2020-09-09T07:48:52.520Z] runbld>>> Adding /usr/lib/jvm/java-8-openjdk-amd64/bin to the path.
[2020-09-09T07:48:52.520Z] Processing JUnit reports with runbld...
[2020-09-09T07:48:52.520Z] + echo 'Processing JUnit reports with runbld...'
[2020-09-09T07:48:53.092Z] runbld>>> <<<<<<<<<<<< SCRIPT EXECUTION END <<<<<<<<<<<<
[2020-09-09T07:48:53.092Z] runbld>>> DURATION: 25ms
[2020-09-09T07:48:53.092Z] runbld>>> STDOUT: 40 bytes
[2020-09-09T07:48:53.092Z] runbld>>> STDERR: 49 bytes
[2020-09-09T07:48:53.092Z] runbld>>> WRAPPED PROCESS: SUCCESS (0)
[2020-09-09T07:48:53.092Z] runbld>>> Searching for build metadata in /var/lib/jenkins/workspace/Beats_beats_PR-21031
[2020-09-09T07:48:54.036Z] runbld>>> Storing build metadata: 
[2020-09-09T07:48:54.036Z] runbld>>> Adding test report.
[2020-09-09T07:48:54.036Z] runbld>>> Searching for junit test output files with the pattern: TEST-.*\.xml$ in: /var/lib/jenkins/workspace/Beats_beats_PR-21031/src/github.com/elastic/beats
[2020-09-09T07:48:54.608Z] runbld>>> Found 0 test output files
[2020-09-09T07:48:54.608Z] runbld>>> Test output logs contained: Errors: 0 Failures: 0 Tests: 0 Skipped: 0
[2020-09-09T07:48:54.868Z] runbld>>> Storing result
[2020-09-09T07:48:55.128Z] runbld>>> Store result: updated {:total 2, :successful 2, :failed 0} 2
[2020-09-09T07:48:55.128Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1597739501209/t/20200909074851-8BF259B4
[2020-09-09T07:48:55.128Z] runbld>>> Email notification disabled by environment variable.
[2020-09-09T07:48:55.128Z] runbld>>> Slack notification disabled by environment variable.
[2020-09-09T07:49:00.706Z] Running on Jenkins in /var/lib/jenkins/workspace/Beats_beats_PR-21031
[2020-09-09T07:49:00.924Z] [INFO] getVaultSecret: Getting secrets
[2020-09-09T07:49:01.032Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-09-09T07:49:02.370Z] + chmod 755 generate-build-data.sh
[2020-09-09T07:49:02.370Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-21031/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-21031/runs/1 FAILURE 1388235
[2020-09-09T07:49:02.370Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-21031/runs/1/steps/?limit=10000 -o steps-info.json
[2020-09-09T07:49:02.921Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-21031/runs/1/tests/?status=FAILED -o tests-errors.json
[2020-09-09T07:49:02.921Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-21031/runs/1/log/ -o pipeline-log.txt

@jsoriano jsoriano added needs_backport PR is waiting to be backported to other branches. v7.10.0 labels Sep 9, 2020
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you please backport this to 7.x branch?

@jalvz jalvz merged commit da2460d into elastic:master Sep 9, 2020
jalvz added a commit to jalvz/beats that referenced this pull request Sep 9, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21031 updated]

  • Start Time: 2020-09-09T08:38:42.595+0000

  • Duration: 71 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 19781
Skipped 1837
Total 21618

jalvz added a commit to jalvz/beats that referenced this pull request Sep 9, 2020
v1v added a commit to v1v/beats that referenced this pull request Sep 14, 2020
* upstream/master: (362 commits)
  Add vendoring to Google Cloud Functions again (elastic#21070)
  [Elastic Agent] Add fleet.host.id for sending to endpoint. (elastic#21042)
  Do not need Google credentials before using it (elastic#21072)
  [Filebeat][New Module] Zoom webhook module (elastic#20414)
  Add support for GMT timezone offset in decode_cef (elastic#20993)
  Filebeat: Fix random error on harvester close (elastic#21048)
  Add ingress controller dashboards (elastic#21052)
  Fix loggers in composable module. (elastic#21047)
  [Ingest Manager] Increase kibana client timeout to 5 minutes (elastic#21037)
  Add changelog. (elastic#21041)
  [Elastic Agent] Add support for EQL based conditions (elastic#20994)
  Disable Kafka metricsets based on Jolokia (elastic#20989)
  Update apm agent (elastic#21031)
  Add container ECS fields in kubernetes metadata (elastic#20984)
  Sanitize event.host in Metricbeat (elastic#21022)
  Update api-keys.asciidoc - API key prerequisites (elastic#21026)
  [Filebeat][suricata] Map x509 for suricata/eve fileset (elastic#20973)
  [Filebeat][santa] Map x509 fields in santa module (elastic#20976)
  [Filebeat][fortinet] Map x509 ecs fields for fortinet fw fileset (elastic#20983)
  Bump zeek kerberos/ssl/x509 ecs version (elastic#21003)
  ...
v1v added a commit to v1v/beats that referenced this pull request Sep 14, 2020
* upstream/master: (364 commits)
  Add vendoring to Google Cloud Functions again (elastic#21070)
  [Elastic Agent] Add fleet.host.id for sending to endpoint. (elastic#21042)
  Do not need Google credentials before using it (elastic#21072)
  [Filebeat][New Module] Zoom webhook module (elastic#20414)
  Add support for GMT timezone offset in decode_cef (elastic#20993)
  Filebeat: Fix random error on harvester close (elastic#21048)
  Add ingress controller dashboards (elastic#21052)
  Fix loggers in composable module. (elastic#21047)
  [Ingest Manager] Increase kibana client timeout to 5 minutes (elastic#21037)
  Add changelog. (elastic#21041)
  [Elastic Agent] Add support for EQL based conditions (elastic#20994)
  Disable Kafka metricsets based on Jolokia (elastic#20989)
  Update apm agent (elastic#21031)
  Add container ECS fields in kubernetes metadata (elastic#20984)
  Sanitize event.host in Metricbeat (elastic#21022)
  Update api-keys.asciidoc - API key prerequisites (elastic#21026)
  [Filebeat][suricata] Map x509 for suricata/eve fileset (elastic#20973)
  [Filebeat][santa] Map x509 fields in santa module (elastic#20976)
  [Filebeat][fortinet] Map x509 ecs fields for fortinet fw fileset (elastic#20983)
  Bump zeek kerberos/ssl/x509 ecs version (elastic#21003)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs_backport PR is waiting to be backported to other branches. Team:apm APM Server team issues/PRs Team:Integrations Label for the Integrations team v7.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants