Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libbeat] Disk queue implementation #21176
[libbeat] Disk queue implementation #21176
Changes from 90 commits
e76a41b
1d8bf65
e8c8128
97a7ed5
f5ad9a2
a78b85c
b12020c
67540d6
94f125c
f29a96f
7ce01f9
a04980e
26b4248
f30f30b
c312d69
1a40b06
ce65718
22ae148
3f5f8fe
61fa5d7
0191dc6
3bf35ff
50bd450
04c9b60
7a2e09a
132ba8e
e73f55f
6d2ca31
988cef6
7774dc4
7146525
1001565
bb56b8f
a99e869
89da2b2
6fa9d33
e77dfa6
d2a65dc
b93fe83
3a3bfcd
cb1107d
3020962
df31c0e
4a22ccd
d4e1dcd
0e12495
56fe5ba
eaf6e2b
5f0376d
d63cbf0
98e61f0
e48c815
1575640
d495aa8
dd08e2c
8db0acf
26d226d
442a513
1a1742e
5ca039d
fdd4be6
f7a446d
79a81de
f88481c
8b61f5b
8c32477
0a6f9f4
91bc3b2
aea4cad
a8ca56a
6d91ab5
767aabb
0bf668e
857077c
d4cd0bb
91ce56f
f9dbfb1
93d3fff
0ac493c
3af1421
333cb76
0dfffe1
43c4aaa
0b33c4b
7b2f4ba
a626cec
53da09a
565a99f
008fbe7
b5ec926
11e55a8
ff04bb5
cc49879
2baf1d4
30cf56c
c619d6a
5b41351
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot of inconsistent error return styles here. Sometimes we wrap an error, sometimes we don't. Unless something else is requesting a specific error type, we might want to just use
errors.wrap
orfmt.Errorf
for everything.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I vote for
fmt.Errorf
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The heuristic I aim for is to ask whether the error being returned is understandable in the context of the caller. For example, errors in the deleter loop aren't wrapped, because they are reported (and grouped / wrapped) when they get back to the core loop, and it looks silly to have a message that looks like "couldn't delete segment file: [couldn't delete segment file: [actual error]]". So for low-level helpers I often leave it unwrapped, knowing that the caller is responsible for reporting it comprehensibly.
That said,
config.go
doesn't seem to follow that convention, and could use a little more verbosity in the messages, so I fixed the calls here :-)