Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #21159 to 7.x: [Filebeat] Add backwards compatibility for append allow_duplicates #21191

Merged
merged 1 commit into from
Sep 21, 2020

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Sep 21, 2020

Cherry-pick of PR #21159 to 7.x branch. Original message:

What does this PR do?

When loading a pipeline this change checks the elasticsearch version
and if the version is less than 7.10.0 it will replace the
"allow_duplicates: false" option with an equivalent if statement on the append
processor.

Why is it important?

This allows filebeat > 7.10.0 to be used with older versions of
elasticsearch. Without it the pipelines fail to load because the
option isn't supported.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 21, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 21, 2020
@marc-gr marc-gr requested a review from a team September 21, 2020 07:12
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21191 opened]

  • Start Time: 2020-09-21T06:55:48.329+0000

  • Duration: 58 min 18 sec

Test stats 🧪

Test Results
Failed 0
Passed 5614
Skipped 833
Total 6447

@marc-gr marc-gr merged commit 95e7e11 into elastic:7.x Sep 21, 2020
@marc-gr marc-gr deleted the backport_21159_7.x branch September 21, 2020 14:11
@zube zube bot removed the [zube]: Done label Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants