-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change defaults shown in doc for to_syslog and to_files #2126
Conversation
@@ -43,12 +43,12 @@ You can specify the following options in the `logging` section of the +{beatname | |||
|
|||
===== to_syslog | |||
|
|||
Sends all logging output to syslog if enabled. For non-Windows systems, the default | |||
value is true. | |||
If enabled, sends all logging output to syslog (on non-Windows systems only). The default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can leave out the "(on non-Windows systems only)" part. It's not common to have a syslog server when running on Windows, but it's technically possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, OK. I included it because I didn't think we would be able to write to a Windows syslog server, but it sounds like we would, so I will remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a late follow-up with some ancillary info, the Golang syslog package isn't implemented on Windows. It has a // +build !windows
build tag.
Good catch! I left a minor comment. |
@tsg Fxed the issue. If it looks OK to you, this is ready to squash and merge now. |
* change defaults shown in doc for to_syslog and to_files * remove mention of Windows
This was missed in PR #1437