change defaults shown in doc for to_syslog and to_files #2126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -43,12 +43,12 @@ You can specify the following options in the `logging` section of the +{beatname | |||
|
|
|||
| ===== to_syslog | |||
|
|
|||
| Sends all logging output to syslog if enabled. For non-Windows systems, the default | |||
| value is true. | |||
| If enabled, sends all logging output to syslog (on non-Windows systems only). The default | |||
There was a problem hiding this comment.
I think we can leave out the "(on non-Windows systems only)" part. It's not common to have a syslog server when running on Windows, but it's technically possible.
There was a problem hiding this comment.
Ah, OK. I included it because I didn't think we would be able to write to a Windows syslog server, but it sounds like we would, so I will remove it.
There was a problem hiding this comment.
Just a late follow-up with some ancillary info, the Golang syslog package isn't implemented on Windows. It has a // +build !windows build tag.
|
Good catch! I left a minor comment. |
|
@tsg Fxed the issue. If it looks OK to you, this is ready to squash and merge now. |
dedemorton
added a commit
to dedemorton/beats
that referenced
this pull request
Jul 30, 2016
* change defaults shown in doc for to_syslog and to_files * remove mention of Windows
tsg
pushed a commit
that referenced
this pull request
Aug 1, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missed in PR #1437