-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure storage metricset values not inside the metricset name #21845
Merged
Merged
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
938e66c
mofidy doc
narph 4daef08
Merge branch 'master' of github.com:elastic/beats
narph b613178
Merge branch 'master' of github.com:elastic/beats
narph 05364cf
Merge branch 'master' of github.com:elastic/beats
narph f147c4d
Merge branch 'master' of github.com:elastic/beats
narph 4574718
Merge branch 'master' of github.com:elastic/beats
narph 1e43077
Merge branch 'master' of github.com:elastic/beats
narph 807cf06
Merge branch 'master' of github.com:elastic/beats
narph 2096668
Merge branch 'master' of github.com:elastic/beats
narph da8ac1f
Merge branch 'master' of github.com:elastic/beats
narph c2d8930
Merge branch 'master' of github.com:elastic/beats
narph 7bd9e73
Merge branch 'master' of github.com:elastic/beats
narph 6e89a84
Merge branch 'master' of github.com:elastic/beats
narph bdf21e9
Merge branch 'master' of github.com:elastic/beats
narph 7833687
Merge branch 'master' of github.com:elastic/beats
narph bbf6178
Merge branch 'master' of github.com:elastic/beats
narph 4ba8817
Merge branch 'master' of github.com:elastic/beats
narph 0cba5dc
Merge branch 'master' of github.com:elastic/beats
narph b2625ca
Merge branch 'master' of github.com:elastic/beats
narph 5100e6a
Merge branch 'master' of github.com:elastic/beats
narph a302d31
Merge branch 'master' of github.com:elastic/beats
narph 631d667
Merge branch 'master' of github.com:elastic/beats
narph 35072a5
Merge branch 'master' of github.com:elastic/beats
narph 4b2f87a
Merge branch 'master' of github.com:elastic/beats
narph f26b533
Merge branch 'master' of github.com:elastic/beats
narph c61620d
Merge branch 'master' of github.com:elastic/beats
narph 43f90c4
Merge branch 'master' of github.com:elastic/beats
narph 2d28f07
Merge branch 'master' of github.com:elastic/beats
narph 0a42bbe
Merge branch 'master' of github.com:elastic/beats
narph 0bedffe
Merge branch 'master' of github.com:elastic/beats
narph 2eb7142
Merge branch 'master' of github.com:elastic/beats
narph f9e4522
Merge branch 'master' of github.com:elastic/beats
narph 227bd50
Merge branch 'master' of github.com:elastic/beats
narph 4bf2bf1
fix
narph 5b19b55
changelog
narph 6e39971
Merge branch 'master' of github.com:elastic/beats
narph a8304e6
Merge branch 'master' into fix-storage
narph 0e85625
Merge branch 'master' of github.com:elastic/beats
narph 99bd66f
Merge branch 'master' into fix-storage
narph File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any way we can test this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unless we change the entire structure of the function and create a mock client etc or having some integration tests in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking forward to those!