Update to sarama v1.10.0 #2190
Merged
Update to sarama v1.10.0 #2190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| TLS: nil, | ||
| Timeout: 30 * time.Second, | ||
| Worker: 1, | ||
| Metadata: metaConfig{ |
There was a problem hiding this comment.
What will happen if these settings are used with an older version of Kafka?
There was a problem hiding this comment.
sarama lib supports kafka 0.8 - 0.10 . Settings should be valid for all kafka versions. Lib might internally ignore settings if they do not apply to the version being used. AFAIK metadata updates and publisher settings should have same effect for kafka versions.
urso
force-pushed
the
upd/sarama-v1.10.0
branch
2 times, most recently
from
06d4598
to
ec5fae2
Compare
urso
added
review
and removed
in progress
| @@ -108,16 +108,28 @@ func (c *client) AsyncPublishEvents( | |||
| topic = event["type"].(string) | |||
| } | |||
|
|
|||
| var ts time.Time | |||
| if c.config.Version.IsAtLeast(sarama.V0_10_0_0) { | |||
There was a problem hiding this comment.
A code comment would be nice that quickly explains why whis is only possible with >= 0.10
|
Doesn't this PR also need an update the libbeat config file? |
urso
force-pushed
the
upd/sarama-v1.10.0
branch
from
ec5fae2
to
29d2dc8
Compare
Ups, yes. |
urso
force-pushed
the
upd/sarama-v1.10.0
branch
2 times, most recently
from
560dfe8
to
75ba5e9
Compare
urso
force-pushed
the
upd/sarama-v1.10.0
branch
from
75ba5e9
to
44da82f
Compare
|
@ruflin added missing config file updates + added options to docs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.