[packaging][beats-tester] use commit id binaries #22027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
andresrc
added
[zube]: Inbox
[zube]: In Review
Team:Automation
botelastic
bot
removed
the
needs_team
zube
bot
added
[zube]: Inbox
needs_team
andresrc
added
[zube]: In Progress
Team:Automation
botelastic
bot
removed
the
needs_team
|
/packaging |
…ter-commit * upstream/master: feat: package aliases for snapshots (elastic#21960) [DOC] Add firewall as possible troubleshooting issue (elastic#21743) [Filebeat] Add max_number_of_messages config parameter for S3 input (elastic#21993) [Elastic Agent] Fix missing elastic_agent event data (elastic#21994) Document auditbeat system process module config (elastic#21766) Update links (elastic#22012)
|
/packaging |
1 similar comment
|
/packaging |
|
/package |
…ter-commit * upstream/master: [Ingest Manager] Use ML_SYSTEM to detect if agent is running as a service (elastic#21884) Prevent log input from sending duplicate messages due to file renaming (elastic#21911)
|
Pinging @elastic/integrations-services (Team:Services) |
| gitCheckout(basedir: "${BASE_DIR}", branch: props.COMMIT) | ||
| } catch(err) { | ||
| // Fallback to the head of the branch as used to be. | ||
| gitCheckout(basedir: "${BASE_DIR}") |
There was a problem hiding this comment.
in case of error getting the artifact the build will continue, Is that correct?
There was a problem hiding this comment.
Yes, just wanted to keep the backward compatibility with the existing behaviour, which it's not ideal, but just in case something bad happens when fetching the artifacts from the upstream build, at least the behaviour will remain working
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
cachedout
approved these changes
Oct 28, 2020
Co-authored-by: cachedout <mike.place@elastic.co>
|
Jenkins run the tests please |
|
/package |
mdelapenya
approved these changes
Oct 29, 2020
v1v
added a commit
to v1v/beats
that referenced
this pull request
Oct 30, 2020
* upstream/master: [JJBB] Add 6.8+ branches (elastic#22321) [CI] Support Windows-8 (elastic#22307) Change cloud.provider from googlecloud to gcp in billing metricset (elastic#22287) [packaging][beats-tester] use commit id binaries (elastic#22027) [CI] Report error in the catch section (elastic#22297)
v1v
added a commit
to v1v/beats
that referenced
this pull request
Oct 30, 2020
* upstream/master: [JJBB] Add 6.8+ branches (elastic#22321) [CI] Support Windows-8 (elastic#22307) Change cloud.provider from googlecloud to gcp in billing metricset (elastic#22287) [packaging][beats-tester] use commit id binaries (elastic#22027) [CI] Report error in the catch section (elastic#22297)
v1v
added a commit
to v1v/beats
that referenced
this pull request
Nov 2, 2020
# Conflicts: # .ci/packaging.groovy # Jenkinsfile
This was referenced Nov 2, 2020
v1v
added a commit
to v1v/beats
that referenced
this pull request
Nov 6, 2020
v1v
added a commit
to v1v/beats
that referenced
this pull request
Nov 6, 2020
v1v
added a commit
that referenced
this pull request
Nov 9, 2020
v1v
added a commit
that referenced
this pull request
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
#21903 in place therefore let's consume those artifacts/binaries, for such, the parentstream will store their build data to be consumed by the downstream jobs.
More context
Packaging
/packagingcomment, therefore it will use the latest commit.Beats tester
Beats tester pipeline that has been triggered by the packaging pipeline then the commit id used for the packaging will be the one used for.
Why is it important?
Avoid known issues when the beats-tester and end2end pipelines consume artifacts that don't match with the upstream build that caused the package generation.
Related issues
Relates #21903
Blocked by elastic/beats-tester#185
Tests
packaging.propertiesis generated to be consumed by thepackagingpipeline ->beats-tester.propertiesis generated to be consumed by thebeats-testerpackaging->beats-tester