Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #22097 to 7.x: [filebeat][suricata] Change x509 mappings from file. to tls.server. #22124

Merged
merged 1 commit into from
Oct 26, 2020

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Oct 23, 2020

Cherry-pick of PR #22097 to 7.x branch. Original message:

What does this PR do?

Changes x509 mappings from being under file to tls.server

Why is it important?

After some conversations with ecs team, we agreed it makes more sense to have them under tls.server in this case.

Checklist

- [ ] My code follows the style guidelines of this project
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have made corresponding change to the default configuration files

  • I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 23, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22124 opened]

  • Start Time: 2020-10-23T07:15:30.528+0000

  • Duration: 77 min 31 sec

Test stats 🧪

Test Results
Failed 0
Passed 1947
Skipped 259
Total 2206

@marc-gr marc-gr requested a review from a team October 23, 2020 09:09
@marc-gr marc-gr merged commit ba2fde8 into elastic:7.x Oct 26, 2020
@marc-gr marc-gr deleted the backport_22097_7.x branch October 26, 2020 09:21
@zube zube bot removed the [zube]: Done label Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants