Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #22236 to 7.10: [Winlogbeat] protect against accessing undefined variables in sysmon module #22242

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

leehinman
Copy link
Contributor

@leehinman leehinman commented Oct 28, 2020

Cherry-pick of PR #22236 to 7.10 branch. Original message:

What does this PR do?

protects against type error when trying to use string functions on
null data type

Why is it important?

Sysmon events fail to index with TypeError

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

go test

Related issues

@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 28, 2020
@leehinman leehinman force-pushed the backport_22236_7.10 branch from d5b3ad2 to b6a068e Compare October 28, 2020 17:27
@elasticmachine
Copy link
Collaborator

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 90
Skipped 0
Total 90

@leehinman leehinman merged commit 6707f15 into elastic:7.10 Oct 28, 2020
@leehinman leehinman deleted the backport_22236_7.10 branch October 28, 2020 19:13
@zube zube bot removed the [zube]: Done label Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants