Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #22261 to 7.10: Fix instance name in perfmon metricset #22411

Merged
merged 2 commits into from
Nov 4, 2020
Merged

Cherry-pick #22261 to 7.10: Fix instance name in perfmon metricset #22411

merged 2 commits into from
Nov 4, 2020

Conversation

narph
Copy link
Contributor

@narph narph commented Nov 4, 2020

Cherry-pick of PR #22261 to 7.10 branch. Original message:

What does this PR do?

Fix instance name in perfmon metricset by adding an additional check in iswildcard function if path contains *

Why is it important?

Fixes instance name in perfmon metricset

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@narph
Fix instance name in perfmon metricset (elastic#22261)
541519e 
* mofidy doc

* fix

* changelog

* add test

(cherry picked from commit f2a55fd)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 4, 2020
@narph narph self-assigned this Nov 4, 2020
@narph narph added backport review Team:Platforms Label for the Integrations - Platforms team labels Nov 4, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 4, 2020
@narph narph added [zube]: In Review needs_team Indicates that the issue/PR needs a Team:* label and removed review labels Nov 4, 2020
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 4, 2020
@botelastic
Copy link

botelastic bot commented Nov 4, 2020

This pull request doesn't have a Team:<team> label.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 4, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22411 updated]

  • Start Time: 2020-11-04T09:55:34.182+0000

  • Duration: 62 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 2195
Skipped 487
Total 2682

@elasticmachine
Copy link
Collaborator

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2195
Skipped 487
Total 2682

@narph narph merged commit 16bf6d6 into elastic:7.10 Nov 4, 2020
@narph narph deleted the backport_22261_7.10 branch November 4, 2020 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

Assignees

@narph narph

Labels
backport Team:Platforms Label for the Integrations - Platforms team [zube]: In Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@narph @elasticmachine @ChrsMark