Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #22531 to 7.x: [Metricbeat] Fix filesystem types on Windows #22544

Merged
merged 2 commits into from
Nov 12, 2020
Merged

Cherry-pick #22531 to 7.x: [Metricbeat] Fix filesystem types on Windows #22544

merged 2 commits into from
Nov 12, 2020

Conversation

andrewstucki
Copy link

@andrewstucki andrewstucki commented Nov 11, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #22531 to 7.x branch. Original message:

What does this PR do?

Fixes the filesystem types that are populated in Metricbeat's filesystem metricset.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

[Metricbeat] Fix filesystem types on Windows (elastic#22531)
ff11143 
* Fix filesystem types on Windows

* Update changelog

* clean up old dependencies

* Update license

(cherry picked from commit 952435b)
@andrewstucki andrewstucki added [zube]: In Review backport Team:Services (Deprecated) Label for the former Integrations-Services team labels Nov 11, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 11, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 11, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 15857
Skipped 1260
Total 17117

@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 11, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22544 updated]

  • Start Time: 2020-11-11T21:38:14.860+0000

  • Duration: 149 min 38 sec

Test stats 🧪

Test Results
Failed 0
Passed 15857
Skipped 1260
Total 17117

@andrewstucki
Copy link
Author

I'm not sure what's up with the Packaging step, or TBH why it's even running for this backport, here are the relevant errors from the build:

[2020-11-11T17:35:55.702Z] Copied 0 artifacts from "Beats » Beats » PR-22544" build number 2

[2020-11-11T17:13:00.941Z] + go get -u github.com/magefile/mage
[2020-11-11T17:13:00.941Z] $GOPATH/go.mod exists but should not
script returned exit code 1

@andrewstucki andrewstucki merged commit 015205f into elastic:7.x Nov 12, 2020
@andrewstucki andrewstucki deleted the backport_22531_7.x branch November 12, 2020 15:05
@zube zube bot removed the [zube]: Done label Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narph narph narph approved these changes

@fearful-symmetry fearful-symmetry Awaiting requested review from fearful-symmetry

Assignees
No one assigned
Labels
backport Team:Services (Deprecated) Label for the former Integrations-Services team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewstucki @elasticmachine @narph