Cherry-pick #22445 to 7.x: Nats module improvements #22614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 70ff0a7)
ChrsMark
added
[zube]: In Review
backport
Team:Platforms
botelastic
bot
added
the
needs_team
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
botelastic
bot
removed
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
marc-gr
reviewed
Nov 17, 2020
| @@ -589,6 +589,19 @@ same journal. {pull}18467[18467] | |||
| - Expand unsupported option from namespace to metrics in the azure module. {pull}21486[21486] | |||
| - Move s3_daily_storage and s3_request metricsets to use cloudwatch input. {pull}21703[21703] | |||
| - Duplicate system.process.cmdline field with process.command_line ECS field name. {pull}22325[22325] | |||
| - Add connection and route metricsets for nats metricbeat module to collect metrics per connection/route. {pull}22445[22445] | |||
There was a problem hiding this comment.
I think some extra lines got here
jsoriano
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #22445 to 7.x branch. Original message:
What this PR adds
This PR adds more metrics at
connectionsandroutesmetricsets. Prior to this no metrics have been collected for each of the connections and for each of the routes. With this PR we collect metrics like in/out bytes etc for each the connections and for each of the routes. In order to have routes in a NATS server a more than 1 NATS servers should be presented creating a NATS cluster. For this docker-compose file of the module adds an extra NATS instance so as populate routes and their respective metrics.Why it is important
It related to elastic/integrations#359. Next steps would be to enhance/improve dashboards.
How to test this manually
docker-composefile of nats moduleconnectionsandroutesmetricsets and point them to the monitoring port of thenatscontainer (exported port of 8222 internal)