Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NATS dashboard #22646

Merged
merged 6 commits into from
Nov 23, 2020
Merged

Update NATS dashboard #22646

merged 6 commits into from
Nov 23, 2020

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Nov 18, 2020

What does this PR do?

This PR updates NATS dashboard with small improvements on currents visualisations and new ones to leverage new connection and route metricsets.

Why is it important?

To update the module before the migration to package.

Screenshot

metricbeat_nats_dashboard

Related to elastic/integrations#359

Signed-off-by: chrismark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark added enhancement :Dashboards Team:Platforms Label for the Integrations - Platforms team labels Nov 18, 2020
@ChrsMark ChrsMark requested a review from jsoriano November 18, 2020 11:05
@ChrsMark ChrsMark self-assigned this Nov 18, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 18, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 18, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22646 updated]

  • Start Time: 2020-11-23T13:29:19.059+0000

  • Duration: 61 min 11 sec

Test stats 🧪

Test Results
Failed 0
Passed 2245
Skipped 510
Total 2755

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2245
Skipped 510
Total 2755

Signed-off-by: chrismark <chrismarkou92@gmail.com>
@jsoriano
Copy link
Member

@ChrsMark dashboard looks good! only one thing. Are the "Timelines" visualizations showing counters continuously growing? Would it make sense to show the derivative instead?

Signed-off-by: chrismark <chrismarkou92@gmail.com>
Signed-off-by: chrismark <chrismarkou92@gmail.com>
@ChrsMark
Copy link
Member Author

@jsoriano good point! I moved monotonically increasing metrics to TSVB to show the rates.

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM, but failure in CI seems related.

Signed-off-by: chrismark <chrismarkou92@gmail.com>
@ChrsMark
Copy link
Member Author

CI issue resolved after #22684. Merging.

@ChrsMark ChrsMark merged commit f5df640 into elastic:master Nov 23, 2020
ChrsMark added a commit to ChrsMark/beats that referenced this pull request Nov 23, 2020
(cherry picked from commit f5df640)
ChrsMark added a commit that referenced this pull request Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Dashboards enhancement Team:Platforms Label for the Integrations - Platforms team v7.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants