Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate fields from system.process to process.* #22845

Merged
merged 6 commits into from
Dec 5, 2020
Merged

Duplicate fields from system.process to process.* #22845

merged 6 commits into from
Dec 5, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Dec 2, 2020

What does this PR do?

This PR is to rename several fields from system.process metricset to process.*. Here is the full list:

  • system.process.state -> process.state
  • system.process.cpu.total.norm.pct -> process.cpu.pct
  • system.process.cpu.start_time -> process.cpu.start_time
  • system.process.memory.rss.pct -> process.memory.pct

cc @fearful-symmetry @mukeshelastic

Why is it important?

This is a part of the inventory schema work for process. Please see #22216 for more details.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 2, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Dec 2, 2020
@kaiyan-sheng kaiyan-sheng added the Team:Platforms Label for the Integrations - Platforms team label Dec 2, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 2, 2020
@kaiyan-sheng kaiyan-sheng added the in progress Pull request is currently in progress. label Dec 2, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 2, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #22845 updated

  • Start Time: 2020-12-04T22:26:55.239+0000

  • Duration: 63 min 39 sec

Test stats 🧪

Test Results
Failed 0
Passed 2320
Skipped 523
Total 2843

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2320
Skipped 523
Total 2843

@andresrc
Copy link
Contributor

andresrc commented Dec 2, 2020

should we do this in the package as well?

@kaiyan-sheng
Copy link
Contributor Author

@andresrc Do you mean adding the new fields into the system integration? I'm planning to create a PR to move it into the integration after this PR is merged.

@kaiyan-sheng kaiyan-sheng added the needs_backport PR is waiting to be backported to other branches. label Dec 3, 2020
@kaiyan-sheng kaiyan-sheng added review and removed in progress Pull request is currently in progress. labels Dec 4, 2020
Copy link
Contributor

@fearful-symmetry fearful-symmetry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaiyan-sheng kaiyan-sheng merged commit 02cf564 into elastic:master Dec 5, 2020
@kaiyan-sheng kaiyan-sheng deleted the process_metrics branch December 5, 2020 01:07
@kaiyan-sheng kaiyan-sheng added v7.11.0 and removed needs_backport PR is waiting to be backported to other branches. labels Dec 5, 2020
kaiyan-sheng added a commit that referenced this pull request Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Team:Platforms Label for the Integrations - Platforms team v7.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants