Add prospector meta data on prospector level to event #2290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change seems to change the event to be only partially by harvester. I see why it makes sense to fill these common setting in prospector, but if possible i'd avoid having to pass partially initialized values. |
|
I think the way it will look in the long run is that there is generic event object which is valid across all prospectors, and each prospector with its harvester will have potential additional fields on top. Somehow reminds me of: #2239 I think the above event is completely valid also without the additional fields from the prospector. As it simplifies the harvester this is a step forward. |
ruflin
force-pushed
the
fb-move-meta-data
branch
from
8c93bb5 to
9166bae
Compare
ruflin
force-pushed
the
fb-move-meta-data
branch
2 times, most recently
from
07fbae2 to
1f78226
Compare
ruflin
added
in progress
ruflin
force-pushed
the
fb-move-meta-data
branch
2 times, most recently
from
e4d0338 to
479e38b
Compare
ruflin
force-pushed
the
fb-move-meta-data
branch
from
479e38b to
7d272db
Compare
ruflin
force-pushed
the
fb-move-meta-data
branch
from
7d272db to
1a6b157
Compare
ruflin
force-pushed
the
fb-move-meta-data
branch
from
1a6b157 to
8945049
Compare
ruflin
force-pushed
the
fb-move-meta-data
branch
2 times, most recently
from
c3f1bf2 to
9111d16
Compare
This simplifies the creation of events on the harvester level and automatically provides the functionality for future types of harvesters. General idea * Harvester should have as few knowledge as possible * Prospector will do the generic creation of the event mergeJSONFields is something that should happen on a prospector level and not be part of the input.Event in the end.
ruflin
force-pushed
the
fb-move-meta-data
branch
from
9111d16 to
0867175
Compare
|
jenkins, retest it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the creation of events on the harvester level and automatically provides the functionality for future types of harvesters