Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve event normalization performance #22974

Merged
merged 3 commits into from
Dec 9, 2020
Merged

Improve event normalization performance #22974

merged 3 commits into from
Dec 9, 2020

Conversation

newly12
Copy link
Contributor

@newly12 newly12 commented Dec 8, 2020 •
edited by jsoriano
Loading

Enhancement

What does this PR do?

Improve event normalization performance

Why is it important?

generalize/normalize is widely used in beats

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Benchmark

Related issues

Use cases

Screenshots

Logs

$ benchstat old.txt new.txt                                                                              
name             old time/op    new time/op    delta
Normalization-8     984ns ±16%     559ns ±13%  -43.16%  (p=0.000 n=20+19)

name             old alloc/op   new alloc/op   delta
Normalization-8    1.18kB ± 0%    0.74kB ± 0%  -37.41%  (p=0.000 n=20+20)

name             old allocs/op  new allocs/op  delta
Normalization-8      13.0 ± 0%       5.0 ± 0%  -61.54%  (p=0.000 n=20+20)

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 8, 2020
@newly12 newly12 mentioned this pull request Dec 8, 2020
Closed
6 tasks
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 8, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: jsoriano commented: jenkins run the tests please

  • Start Time: 2020-12-09T12:26:46.807+0000

  • Duration: 64 min 25 sec

Test stats 🧪

Test Results
Failed 0
Passed 17361
Skipped 1373
Total 18734

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 17361
Skipped 1373
Total 18734

@jsoriano jsoriano added the Team:Services (Deprecated) Label for the former Integrations-Services team label Dec 8, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 8, 2020
@jsoriano jsoriano added needs_backport PR is waiting to be backported to other branches. v7.11.0 labels Dec 8, 2020
@jsoriano
Copy link
Member

jsoriano commented Dec 8, 2020

jenkins run the tests please

@jsoriano
Copy link
Member

jsoriano commented Dec 8, 2020

This looks like a promising change, thanks @newly12!

@andresrc andresrc requested review from jsoriano and urso December 9, 2020 11:21
@jsoriano
Copy link
Member

jsoriano commented Dec 9, 2020

jenkins run the tests please

@urso urso merged commit d9d337c into elastic:master Dec 9, 2020
@urso
Copy link

urso commented Dec 9, 2020

Merged. The change will be available in 7.11. I will take care of backporting.

Thank you for your contribution.

@urso urso self-assigned this Dec 9, 2020
@urso urso mentioned this pull request Dec 9, 2020
Merged
6 tasks
@urso urso removed the needs_backport PR is waiting to be backported to other branches. label Dec 9, 2020
@newly12 newly12 deleted the normalizerProcessor2 branch December 10, 2020 01:26
urso pushed a commit to urso/beats that referenced this pull request Dec 14, 2020
@newly12
Improve event normalization performance (elastic#22974)
90485ab 
Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
(cherry picked from commit d9d337c)
urso pushed a commit that referenced this pull request Dec 14, 2020
@jsoriano @newly12
Cherry-pick #22974 to 7.x: Improve event normalization performance (#…
42c5abf 
…23029)

Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
Co-authored-by: Peter Deng <yundeng@ebay.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urso urso urso approved these changes

@jsoriano jsoriano jsoriano approved these changes

Assignees

@urso urso

Labels
Team:Services (Deprecated) Label for the former Integrations-Services team v7.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@newly12 @elasticmachine @jsoriano @urso