Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to go 1.7 #2306

Merged
merged 1 commit into from
Aug 18, 2016
Merged

Switch to go 1.7 #2306

merged 1 commit into from
Aug 18, 2016

Conversation

tsg
Copy link
Contributor

@tsg tsg commented Aug 18, 2016

This also updates the OS X cross compiler used in pacakging to use the 10.11
SDK. Credit for figuring out what's needed goes to the upstream project
github.com/karalabe/xgo.

@tsg tsg added the review label Aug 18, 2016
@tsg
Copy link
Contributor Author

tsg commented Aug 18, 2016

jenkins, package it

@tsg
Copy link
Contributor Author

tsg commented Aug 18, 2016

@ruflin i ended up doing a new PR because your #2276 was needing a rebase anyway. Can you check that I didn't miss anything that you had in it?

@@ -0,0 +1 @@
<html><body>You are being <a href="https://raw.githubusercontent.com/karalabe/xgo/master/docker/base/patch.tar.xz">redirected</a>.</body></html>
Copy link
Member

@andrewkroh andrewkroh Aug 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it didn't follow a redirect on download. And I think it's what jenkins failed on.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, strange that it seemed to work on my computers. Ooops.

@tsg
Copy link
Contributor Author

tsg commented Aug 18, 2016

jenkins, package it

@tsg
Copy link
Contributor Author

tsg commented Aug 18, 2016

@ruflin
Copy link
Contributor

ruflin commented Aug 18, 2016

@tsg I think you missed some appveyor lines

@ruflin
Copy link
Contributor

ruflin commented Aug 18, 2016

Ah, and update the CHANGELOG.

This also updates the OS X cross compiler used in pacakging to use the 10.11
SDK. Credit for figuring out what's needed goes to the upstream project
github.com/karalabe/xgo.
@ruflin ruflin mentioned this pull request Aug 18, 2016
@andrewkroh andrewkroh merged commit 86c9282 into elastic:master Aug 18, 2016
tsg pushed a commit to tsg/beats-packer that referenced this pull request Aug 18, 2016
Mostly copied the files from elastic/beats#2306.
@ruflin ruflin mentioned this pull request Aug 18, 2016
@tsg tsg deleted the go_1.7 branch August 25, 2016 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants