Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #23068 to 7.x: [Filebeat] Allow cisco/asa and cisco/ftd modules to override network directionality based off of zones #23084

Merged
merged 2 commits into from
Dec 10, 2020
Merged

Cherry-pick #23068 to 7.x: [Filebeat] Allow cisco/asa and cisco/ftd modules to override network directionality based off of zones #23084

merged 2 commits into from
Dec 10, 2020

Conversation

andrewstucki
Copy link

@andrewstucki andrewstucki commented Dec 10, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #23068 to 7.x branch. Original message:

What does this PR do?

This adopts the same logic as #22998 by classifying internal/external/inbound/outbound traffic based off of zones. The implementation is similar to #23066 in that the zone-based classification is off by default, since the cisco logs already classify inbound/outbound for you.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

[Filebeat] Allow cisco/asa and cisco/ftd modules to override network …
72145bf 
…directionality based off of zones (elastic#23068)

* [Filebeat] Allow cisco/asa and cisco/ftd modules to override network directionality based off of zones

* Add changelog entry

* Don't override categorization if no zone set

* regenerate golden files

(cherry picked from commit 76b7c8c)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 10, 2020
@andrewstucki andrewstucki requested a review from a team December 10, 2020 21:55
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 10, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Started by user Andrew Stucki

  • Start Time: 2020-12-10T22:06:31.098+0000

  • Duration: 55 min 59 sec

Test stats 🧪

Test Results
Failed 0
Passed 2413
Skipped 261
Total 2674

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2413
Skipped 261
Total 2674

@andrewstucki andrewstucki merged commit e1b7ebe into elastic:7.x Dec 10, 2020
@andrewstucki andrewstucki deleted the backport_23068_7.x branch December 10, 2020 23:21
@zube zube bot removed the [zube]: Done label Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leehinman leehinman leehinman approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewstucki @elasticmachine @leehinman