Cherry-pick #23070 to 7.x: [Filebeat] MISP improvements #23100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
botelastic
bot
removed
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
adriansr
previously requested changes
Dec 14, 2020
marc-gr
force-pushed
the
backport_23070_7.x
branch
from
bfe1a2b to
25e73d9
Compare
- Add id based on body uuid - Add pagination and cursor - Migrate to httpjson v2 (cherry picked from commit e0d654a)
marc-gr
force-pushed
the
backport_23070_7.x
branch
from
25e73d9 to
cdab339
Compare
andrewstucki
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #23070 to 7.x branch. Original message:
What does this PR do?
Why is it important?
MISP current implementation was lacking pagination or state, making it a bit complicated to be used in production set ups. This changes take advantage of the new httpjson v2 features to improve the module.
Checklist
- [] My code follows the style guidelines of this project- [ ] I have commented my code, particularly in hard-to-understand areasCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.