Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] Copy synthetics suites to tmpdir before running #23347

Closed
wants to merge 3 commits into from

Conversation

andrewvc
Copy link
Contributor

@andrewvc andrewvc commented Jan 4, 2021

The rationale here is that doing so resolves any file permissions issues that may be present due to the suite directory being shared to the container as read only OR due to incompatible UIDs between the docker container and the host.

Fixes elastic/synthetics#156

As a note, no tests are added here due to the complexity of testing this small amount of I/O functionality, however, any issues should be caught by our E2E tests in https://github.com/elastic/synthetics/tree/master/__tests__/e2e . I've opened an issue to improve this situation here: #23346

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

You can test this manually by running mage build && ./heartbeat -e --path.config sample-synthetics-config/ and ensuring that there's still output.

The rationale here is that doing so resolves any file permissions issues
that may be present due to the suite directory being shared to the
container as read only OR due to incompatible UIDs between the docker
container and the host.

Fixes elastic/synthetics#156
@andrewvc andrewvc added enhancement Team:obs-ds-hosted-services Label for the Observability Hosted Services team v7.12.0 labels Jan 4, 2021
@andrewvc andrewvc requested a review from blakerouse January 4, 2021 20:26
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jan 4, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 4, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23347 updated

  • Start Time: 2021-01-04T20:36:17.970+0000

  • Duration: 22 min 17 sec

Test stats 🧪

Test Results
Failed 0
Passed 953
Skipped 13
Total 966

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 953
Skipped 13
Total 966

@andrewvc andrewvc requested a review from a team as a code owner January 4, 2021 20:35
@andrewvc
Copy link
Contributor Author

Closing in favor of #23467

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team v7.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker example doesn't work well with uids != 1000
2 participants