Fix docs of MSSQL filebeat module referencing Traefik plus change paths from Linux to MS Windows #23360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayden
added
docs
Filebeat
|
Pinging @elastic/integrations-services (Team:Services) |
botelastic
bot
added
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
jsoriano
reviewed
Jan 14, 2021
filebeat/docs/modules/mssql.asciidoc
Outdated
|
|
||
| ["source","yaml",subs="attributes"] | ||
| ----- | ||
| - module: mssql | ||
| log: | ||
| enabled: true | ||
| var.paths: ["/var/opt/mssql/log/error*"] | ||
| var.paths: ["C:\Program Files\Microsoft SQL Server\MSSQL.150\MSSQL\LOG\ERRORLOG*"] |
There was a problem hiding this comment.
Backslashes in YAML need to be escaped or single-quoted:
Suggested change
| var.paths: ["C:\Program Files\Microsoft SQL Server\MSSQL.150\MSSQL\LOG\ERRORLOG*"] | |
| var.paths: ['C:\Program Files\Microsoft SQL Server\MSSQL.150\MSSQL\LOG\ERRORLOG*'] |
|
Thanks Jaime! |
sayden
added a commit
to sayden/beats
that referenced
this pull request
Jan 19, 2021
…hs from Linux to MS Windows (elastic#23360) (cherry picked from commit 739f820)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes MSSQL docs that had references to Traefik plus changing the config paths from a Linux based path (also compatible with MSSQL) to a MS Windows path, which is probably more common.
Related issues