Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] Fix ASA/FTD Sample Log lines #23526

Closed
wants to merge 1 commit into from

Conversation

hitchatwork
Copy link
Contributor

  • Bug

What does this PR do?

Fixed malformed log sample on line 41 of ASA and FTD log samples (had text 'port>' at the end of the port number; shouldn't be there per cisco docs)

Why is it important?

Prevent need to make changes to ingest parsing to account for bad log line

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

… text 'port>' at the end of the port number; shouldn't be there per cisco docs)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 15, 2021
@elasticmachine
Copy link
Collaborator

❕ Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts

Expand to view the summary

Build stats

  • Build Cause: Pull request #23526 opened

  • Reason: The PR is not allowed to run in the CI yet

    • Start Time: 2021-01-15T10:53:31.633+0000
  • Duration: 4 min 39 sec

  • Commit: 97255bf

Steps errors 1

Expand to view the steps failures

Error signal
  • Took 0 min 0 sec . View more details on here
  • Description: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permissions can do so.)

Log output

Expand to view the last 100 lines of log output

[2021-01-15T10:55:14.049Z] Checking out Revision 97255bf1d41184e9f252a73f2eae148bb4dbab6e (PR-23526)
[2021-01-15T10:55:14.020Z]  > git remote # timeout=10
[2021-01-15T10:55:14.024Z]  > git config --get remote.origin.url # timeout=10
[2021-01-15T10:55:14.028Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2021-01-15T10:55:14.031Z]  > git merge 8d2c7237ef366968cd2a41aec5111233950e0fc8 # timeout=10
[2021-01-15T10:55:14.041Z]  > git rev-parse HEAD^{commit} # timeout=10
[2021-01-15T10:55:14.050Z]  > git config core.sparsecheckout # timeout=10
[2021-01-15T10:55:14.057Z]  > git checkout -f 97255bf1d41184e9f252a73f2eae148bb4dbab6e # timeout=15
[2021-01-15T10:55:19.027Z] Commit message: "Fixed malformed log sample on line 41 of ASA and FTD log samples (had text 'port>' at the end of the port number; shouldn't be there per cisco docs)"
[2021-01-15T10:55:19.028Z] First time build. Skipping changelog.
[2021-01-15T10:55:19.028Z] Cleaning workspace
[2021-01-15T10:55:19.179Z]  > git --version # timeout=10
[2021-01-15T10:55:19.182Z]  > git --version # 'git version 2.17.1'
[2021-01-15T10:55:19.186Z] fatal: bad object 8ef7113ea954c8d30e3eacac47c5b9985f1cc306
[2021-01-15T10:55:19.029Z]  > git rev-parse --verify HEAD # timeout=10
[2021-01-15T10:55:19.032Z] Resetting working tree
[2021-01-15T10:55:19.032Z]  > git reset --hard # timeout=10
[2021-01-15T10:55:19.110Z]  > git clean -fdx # timeout=10
[2021-01-15T10:55:20.251Z] Timeout set to expire in 3 hr 0 min
[2021-01-15T10:55:20.286Z] The timestamps step is unnecessary when timestamps are enabled for all Pipeline builds.
[2021-01-15T10:55:20.591Z] [INFO] Number of builds to be searched 10
[2021-01-15T10:55:21.252Z] [INFO] 'shallow' is forced to be disabled when running on PullRequests
[2021-01-15T10:55:21.278Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-23526/src/github.com/elastic/beats
[2021-01-15T10:55:21.317Z] [INFO] gitCheckout: Checkout SCM PR-23526 with default customisation from the Item.
[2021-01-15T10:55:21.354Z] [INFO] Override default checkout
[2021-01-15T10:55:21.416Z] Sleeping for 10 sec
[2021-01-15T10:55:31.445Z] The recommended git tool is: git
[2021-01-15T10:55:31.495Z] using credential f6c7695a-671e-4f4f-a331-acdce44ff9ba
[2021-01-15T10:55:31.529Z] Wiping out workspace first.
[2021-01-15T10:55:31.537Z] Cloning the remote Git repository
[2021-01-15T10:55:31.537Z] Using shallow clone with depth 10
[2021-01-15T10:55:31.537Z] Avoid fetching tags
[2021-01-15T10:55:31.548Z] Cloning repository git@github.com:elastic/beats.git
[2021-01-15T10:55:31.568Z]  > git init /var/lib/jenkins/workspace/Beats_beats_PR-23526/src/github.com/elastic/beats # timeout=10
[2021-01-15T10:55:31.574Z] Fetching upstream changes from git@github.com:elastic/beats.git
[2021-01-15T10:55:31.574Z]  > git --version # timeout=10
[2021-01-15T10:55:31.578Z]  > git --version # 'git version 2.17.1'
[2021-01-15T10:55:31.578Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2021-01-15T10:55:31.582Z]  > git fetch --no-tags --progress -- git@github.com:elastic/beats.git +refs/heads/*:refs/remotes/origin/* # timeout=15
[2021-01-15T10:55:50.143Z] Cleaning workspace
[2021-01-15T10:55:50.155Z] Using shallow fetch with depth 10
[2021-01-15T10:55:50.155Z] Pruning obsolete local branches
[2021-01-15T10:55:50.126Z]  > git config remote.origin.url git@github.com:elastic/beats.git # timeout=10
[2021-01-15T10:55:50.129Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
[2021-01-15T10:55:50.137Z]  > git config remote.origin.url git@github.com:elastic/beats.git # timeout=10
[2021-01-15T10:55:50.143Z]  > git rev-parse --verify HEAD # timeout=10
[2021-01-15T10:55:50.146Z] No valid HEAD. Skipping the resetting
[2021-01-15T10:55:50.146Z]  > git clean -fdx # timeout=10
[2021-01-15T10:55:50.156Z] Fetching upstream changes from git@github.com:elastic/beats.git
[2021-01-15T10:55:50.156Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2021-01-15T10:55:50.160Z]  > git fetch --no-tags --progress --prune -- git@github.com:elastic/beats.git +refs/pull/23526/head:refs/remotes/origin/PR-23526 +refs/heads/master:refs/remotes/origin/master # timeout=15
[2021-01-15T10:55:51.246Z] Merging remotes/origin/master commit 8d2c7237ef366968cd2a41aec5111233950e0fc8 into PR head commit 97255bf1d41184e9f252a73f2eae148bb4dbab6e
[2021-01-15T10:55:52.718Z] Merge succeeded, producing 97255bf1d41184e9f252a73f2eae148bb4dbab6e
[2021-01-15T10:55:52.719Z] Checking out Revision 97255bf1d41184e9f252a73f2eae148bb4dbab6e (PR-23526)
[2021-01-15T10:55:51.246Z]  > git config core.sparsecheckout # timeout=10
[2021-01-15T10:55:51.249Z]  > git checkout -f 97255bf1d41184e9f252a73f2eae148bb4dbab6e # timeout=15
[2021-01-15T10:55:52.692Z]  > git remote # timeout=10
[2021-01-15T10:55:52.695Z]  > git config --get remote.origin.url # timeout=10
[2021-01-15T10:55:52.699Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2021-01-15T10:55:52.702Z]  > git merge 8d2c7237ef366968cd2a41aec5111233950e0fc8 # timeout=10
[2021-01-15T10:55:52.712Z]  > git rev-parse HEAD^{commit} # timeout=10
[2021-01-15T10:55:52.719Z]  > git config core.sparsecheckout # timeout=10
[2021-01-15T10:55:52.722Z]  > git checkout -f 97255bf1d41184e9f252a73f2eae148bb4dbab6e # timeout=15
[2021-01-15T10:55:53.862Z] Commit message: "Fixed malformed log sample on line 41 of ASA and FTD log samples (had text 'port>' at the end of the port number; shouldn't be there per cisco docs)"
[2021-01-15T10:55:53.862Z] Cleaning workspace
[2021-01-15T10:55:54.010Z]  > git --version # timeout=10
[2021-01-15T10:55:54.014Z]  > git --version # 'git version 2.17.1'
[2021-01-15T10:55:54.017Z] fatal: bad object 8ef7113ea954c8d30e3eacac47c5b9985f1cc306
[2021-01-15T10:55:53.862Z]  > git rev-parse --verify HEAD # timeout=10
[2021-01-15T10:55:53.866Z] Resetting working tree
[2021-01-15T10:55:53.866Z]  > git reset --hard # timeout=10
[2021-01-15T10:55:53.945Z]  > git clean -fdx # timeout=10
[2021-01-15T10:55:55.121Z] Masking supported pattern matches of $GIT_USERNAME or $GIT_PASSWORD
[2021-01-15T10:55:55.765Z] + git fetch https://****:****@github.com/elastic/beats.git +refs/pull/*/head:refs/remotes/origin/pr/*
[2021-01-15T10:57:03.545Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-23526/src/github.com/elastic/beats/.git
[2021-01-15T10:57:03.583Z] Archiving artifacts
[2021-01-15T10:57:04.309Z] + git rev-parse HEAD
[2021-01-15T10:57:04.640Z] + git rev-parse HEAD
[2021-01-15T10:57:04.946Z] + git rev-parse origin/pr/23526
[2021-01-15T10:57:04.999Z] [INFO] githubEnv: Found Git Build Cause: pr
[2021-01-15T10:57:05.362Z] Masking supported pattern matches of $GITHUB_TOKEN
[2021-01-15T10:57:06.537Z] [WARN] githubApiCall: The REST API call https://api.github.com/repos/elastic/beats/pulls/23526/reviews return 0 elements
[2021-01-15T10:57:06.654Z] [INFO] githubPrCheckApproved: Title: [Filebeat] Fix ASA/FTD Sample Log lines - User: hitchatwork - Author Association: CONTRIBUTOR
[2021-01-15T10:57:07.211Z] ERROR: githubPrCheckApproved: The PR is not allowed to run in the CI yet
[2021-01-15T10:57:07.211Z] ERROR: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permissions can do so.)
[2021-01-15T10:57:07.403Z] [INFO] Let's stop build #1. The PR is not allowed to run in the CI yet
[2021-01-15T10:57:07.451Z] Sleeping for 5 sec
[2021-01-15T10:57:08.839Z] Stage "Lint" skipped due to earlier failure(s)
[2021-01-15T10:57:08.923Z] Stage "Build&Test" skipped due to earlier failure(s)
[2021-01-15T10:57:09.008Z] Stage "Packaging" skipped due to earlier failure(s)
[2021-01-15T10:57:09.118Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-23526/src/github.com/elastic/beats
[2021-01-15T10:57:09.819Z] Running on Jenkins in /var/lib/jenkins/workspace/Beats_beats_PR-23526
[2021-01-15T10:57:10.085Z] [INFO] getVaultSecret: Getting secrets
[2021-01-15T10:57:10.179Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2021-01-15T10:57:11.097Z] + chmod 755 generate-build-data.sh
[2021-01-15T10:57:11.097Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-23526/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-23526/runs/1 ABORTED 219193
[2021-01-15T10:57:11.648Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-23526/runs/1/steps/?limit=10000 -o steps-info.json
[2021-01-15T10:57:12.199Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-23526/runs/1/tests/?status=FAILED -o tests-errors.json
[2021-01-15T10:57:12.450Z] Retry 1/3 exited 22, retrying in 1 seconds...
[2021-01-15T10:57:13.361Z] Retry 2/3 exited 22, retrying in 2 seconds...

@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 15, 2021
@andrewkroh
Copy link
Member

Thanks @hitchatwork, this got fixed in #21196 so I'll close this one.

@andrewkroh andrewkroh closed this Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants