-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add container image and container name ECS fields for state_container #23802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chrismark <chrismarkou92@gmail.com>
ChrsMark
added
review
containers
Related to containers use case
ecs
v7.12.0
kubernetes
Enable builds in the CI for kubernetes
labels
Feb 2, 2021
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Feb 2, 2021
This was referenced Feb 2, 2021
Signed-off-by: chrismark <chrismarkou92@gmail.com>
Collaborator
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
Pinging @elastic/integrations (Team:Integrations) |
botelastic
bot
removed
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Feb 2, 2021
jsoriano
approved these changes
Feb 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but linting issues are related.
ChrsMark
added a commit
to ChrsMark/beats
that referenced
this pull request
Feb 2, 2021
…elastic#23802) (cherry picked from commit 50a8f10)
ChrsMark
added a commit
that referenced
this pull request
Feb 2, 2021
This was referenced Mar 5, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
containers
Related to containers use case
ecs
kubernetes
Enable builds in the CI for kubernetes
review
Team:Integrations
Label for the Integrations team
v7.12.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Most probably this was not caught at #13884.
With this PR
kubernetes.container.name
is being copied tocontainer.name
andkubernetes.container.name
is being copied tocontainer.image.name
based on container ECS.kubernetes.container.*
fields will not be removed until 8.0 elastic stack release.Related to #23585