-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
management.Status constants could not be used directly in log #23849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This add stringer generator to the Status const to allow them to be understood by a human in log. ref: elastic#23812
Pinging @elastic/agent (Team:Agent) |
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Feb 4, 2021
botelastic
bot
removed
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Feb 4, 2021
This pull request doesn't have a |
Pinging @elastic/ingest-management (Team:Ingest Management) |
Collaborator
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
urso
approved these changes
Feb 4, 2021
urso
reviewed
Feb 4, 2021
Merged
6 tasks
ph
added a commit
to ph/beats
that referenced
this pull request
Feb 4, 2021
…c#23849) * management.Status constants could not be used directly in log This add stringer generator to the Status const to allow them to be understood by a human in log. ref: elastic#23812 (cherry picked from commit a52c744)
ph
added a commit
that referenced
this pull request
Feb 5, 2021
…sed directly in log (#23861) * management.Status constants could not be used directly in log (#23849) * management.Status constants could not be used directly in log This add stringer generator to the Status const to allow them to be understood by a human in log. ref: #23812 (cherry picked from commit a52c744)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add a stringer generator to the Status const to allow them to be
understood by a human in log.
ref: #23812
What does this PR do?
Why is it important?
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs