Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

management.Status constants could not be used directly in log #23849

Merged
merged 3 commits into from
Feb 4, 2021

Conversation

ph
Copy link
Contributor

@ph ph commented Feb 4, 2021

This add a stringer generator to the Status const to allow them to be
understood by a human in log.

ref: #23812

What does this PR do?

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

This add stringer generator to the Status const to allow them to be
understood by a human in log.

ref: elastic#23812
@ph ph added the Team:Elastic-Agent Label for the Agent team label Feb 4, 2021
@ph ph requested a review from a team February 4, 2021 13:45
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 4, 2021
@ph ph added needs_team Indicates that the issue/PR needs a Team:* label review labels Feb 4, 2021
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 4, 2021
@botelastic
Copy link

botelastic bot commented Feb 4, 2021

This pull request doesn't have a Team:<team> label.

@ph ph self-assigned this Feb 4, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 4, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23849 updated

    • Start Time: 2021-02-04T16:55:39.370+0000
  • Duration: 48 min 5 sec

  • Commit: d931eae

Test stats 🧪

Test Results
Failed 0
Passed 45473
Skipped 4738
Total 50211

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 45473
Skipped 4738
Total 50211

@ph ph merged commit a52c744 into elastic:master Feb 4, 2021
@ph ph added the v7.12.0 label Feb 4, 2021
ph added a commit to ph/beats that referenced this pull request Feb 4, 2021
…c#23849)

* management.Status constants could not be used directly in log

This add stringer generator to the Status const to allow them to be
understood by a human in log.

ref: elastic#23812
(cherry picked from commit a52c744)
ph added a commit that referenced this pull request Feb 5, 2021
…sed directly in log (#23861)

* management.Status constants could not be used directly in log (#23849)

* management.Status constants could not be used directly in log

This add stringer generator to the Status const to allow them to be
understood by a human in log.

ref: #23812
(cherry picked from commit a52c744)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants