-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ingest Manager] Windows agent doesn't uninstall with a lowercase c:
drive in the path
#23998
Merged
michalpristas
merged 5 commits into
elastic:master
from
michalpristas:fix/uninstall-lower
Feb 11, 2021
Merged
[Ingest Manager] Windows agent doesn't uninstall with a lowercase c:
drive in the path
#23998
michalpristas
merged 5 commits into
elastic:master
from
michalpristas:fix/uninstall-lower
Feb 11, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/agent (Team:Agent) |
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
Team:Ingest Management
labels
Feb 11, 2021
Pinging @elastic/ingest-management (Team:Ingest Management) |
botelastic
bot
removed
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Feb 11, 2021
michalpristas
changed the title
case sensitivity in path comparison
[Ingest Manager] Windows agent doesn't uninstall with a lowercase Feb 11, 2021
c:
drive in the path
Collaborator
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
ph
approved these changes
Feb 11, 2021
michalpristas
added a commit
to michalpristas/beats
that referenced
this pull request
Feb 11, 2021
…` drive in the path (elastic#23998) [Ingest Manager] Windows agent doesn't uninstall with a lowercase `c:` drive in the path (elastic#23998)
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes uninstall check case sensitivity.
The problem was with windows that paths does not need to match case to work. New Func was added which either check strings for equality(darwin,linux) or checks them in case insensitive way (windows)
Why is it important?
Fixes #22268
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.