Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Manager] Windows agent doesn't uninstall with a lowercase c: drive in the path #23998

Merged
merged 5 commits into from
Feb 11, 2021

Conversation

michalpristas
Copy link
Contributor

@michalpristas michalpristas commented Feb 11, 2021

What does this PR do?

This PR fixes uninstall check case sensitivity.
The problem was with windows that paths does not need to match case to work. New Func was added which either check strings for equality(darwin,linux) or checks them in case insensitive way (windows)

Why is it important?

Fixes #22268

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@michalpristas michalpristas added bug Team:Elastic-Agent Label for the Agent team labels Feb 11, 2021
@michalpristas michalpristas self-assigned this Feb 11, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label Team:Ingest Management labels Feb 11, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 11, 2021
@michalpristas michalpristas changed the title case sensitivity in path comparison [Ingest Manager] Windows agent doesn't uninstall with a lowercase c: drive in the path Feb 11, 2021
@michalpristas michalpristas requested a review from ph February 11, 2021 13:31
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 11, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23998 updated

  • Start Time: 2021-02-11T13:36:58.412+0000

  • Duration: 28 min 45 sec

  • Commit: 9e87734

Test stats 🧪

Test Results
Failed 0
Passed 5902
Skipped 16
Total 5918

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 5902
Skipped 16
Total 5918

@michalpristas michalpristas merged commit d1e8b25 into elastic:master Feb 11, 2021
michalpristas added a commit to michalpristas/beats that referenced this pull request Feb 11, 2021
…` drive in the path (elastic#23998)

[Ingest Manager] Windows agent doesn't uninstall with a lowercase `c:` drive in the path  (elastic#23998)
michalpristas added a commit that referenced this pull request Feb 11, 2021
…ercase `c:` drive in the path (#24003)

Cherry-pick #23998 to 7.x: Windows agent doesn't uninstall with a lowercase `c:` drive in the path (#24003)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows Agent doesn't uninstall with a lowercase c: drive in the path
3 participants