Store cloudfoundry.container.cpu.pct in decimal form #24219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Percentages should be stored in decimal form, and can be stored as scaled floats. Some code is refactored to remove previous helper that makes less sense now.
jsoriano
added
review
Metricbeat
|
Pinging @elastic/integrations (Team:Integrations) |
botelastic
bot
added
needs_team
|
This pull request doesn't have a |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
kaiyan-sheng
approved these changes
Feb 24, 2021
6 tasks
jsoriano
added
v7.13.0
and removed
needs_backport
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Feb 25, 2021
Percentages should be stored in decimal form, and can be stored as scaled floats. Some code is refactored to remove previous helper that makes less sense now. (cherry picked from commit 2cf650c)
jsoriano
added a commit
that referenced
this pull request
Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
cloudfoundry.container.cpu.pctin decimal form.scaled_float.Change is breaking, but it doesn't affect to existing dashboards, and this module is in beta stage.
Why is it important?
It is preferred to store percentages in decimal form, and
scaled_floatis enough to store them.Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues