Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest-Manager] Fix capabilities resolution in inspect command #24346

Merged
merged 3 commits into from
Mar 5, 2021

Conversation

michalpristas
Copy link
Contributor

@michalpristas michalpristas commented Mar 4, 2021

What does this PR do?

This one was reported by @faec during testing.

When using inspect command type of object is resolved as map[interface{}]interface{} instead of usual map[string]interface{}
This PR allows capabilities handle this type as well.

Why is it important?

Resolve same config in pipeline and inspect

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@michalpristas michalpristas added bug needs_backport PR is waiting to be backported to other branches. Team:Ingest Management v7.12.0 Team:Elastic-Agent Label for the Agent team labels Mar 4, 2021
@michalpristas michalpristas self-assigned this Mar 4, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 4, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 4, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24346 updated

  • Start Time: 2021-03-05T15:00:50.894+0000

  • Duration: 107 min 9 sec

  • Commit: fb80485

Test stats 🧪

Test Results
Failed 0
Passed 6548
Skipped 16
Total 6564

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 6548
Skipped 16
Total 6564

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprising that it can sometimes be map[interface{}]interface{}. I assume that is because of user misconfiguration?

@michalpristas
Copy link
Contributor Author

it depends where it's coming from and action or ast it is correct if it's from config it's this way.

@michalpristas michalpristas merged commit 7d16076 into elastic:master Mar 5, 2021
michalpristas added a commit to michalpristas/beats that referenced this pull request Mar 5, 2021
…tic#24346)

[Ingest-Manager] Fix capabilities resolution in inspect command (elastic#24346)
michalpristas added a commit to michalpristas/beats that referenced this pull request Mar 5, 2021
…tic#24346)

[Ingest-Manager] Fix capabilities resolution in inspect command (elastic#24346)
michalpristas added a commit that referenced this pull request Mar 6, 2021
…) (#24399)

[Ingest-Manager] Fix capabilities resolution in inspect command (#24346)
michalpristas added a commit that referenced this pull request Mar 6, 2021
…) (#24400)

[Ingest-Manager] Fix capabilities resolution in inspect command (#24346)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs_backport PR is waiting to be backported to other branches. Team:Elastic-Agent Label for the Agent team v7.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants