-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ingest-Manager] Fix capabilities resolution in inspect command #24346
Conversation
Pinging @elastic/ingest-management (Team:Ingest Management) |
Pinging @elastic/agent (Team:Agent) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surprising that it can sometimes be map[interface{}]interface{}
. I assume that is because of user misconfiguration?
it depends where it's coming from and action or ast it is correct if it's from config it's this way. |
…tic#24346) [Ingest-Manager] Fix capabilities resolution in inspect command (elastic#24346)
…tic#24346) [Ingest-Manager] Fix capabilities resolution in inspect command (elastic#24346)
…tic#24346) (elastic#24399) [Ingest-Manager] Fix capabilities resolution in inspect command (elastic#24346)
What does this PR do?
This one was reported by @faec during testing.
When using inspect command type of object is resolved as
map[interface{}]interface{}
instead of usualmap[string]interface{}
This PR allows capabilities handle this type as well.
Why is it important?
Resolve same config in pipeline and inspect
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.