Cleanup Filebeat publishers #2463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ruflin
commented
Sep 5, 2016
•
ruflin
commented
- Separate async and sync publisher into own files
- Add Publish interface method which can be used to manually trigger publish (see Allow filebeat to only run once #2456)
- Add getDataEvents function
- Rename publish to publisher package
| func (p *asyncLogPublisher) Publish() error { | ||
| select { | ||
| case <-p.done: | ||
| return fmt.Errorf("async publisher stopped") |
There was a problem hiding this comment.
Changed for all occurences
* Separate async and sync publisher into own files * Add Publish interface method which can be used to manually trigger publish (see elastic#2456) * Add getDataEvents function * Rename publish to publisher package
ruflin
force-pushed
the
cleanup-publisher
branch
from
9b5edb1 to
7dac29e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.