Improve handling of messages larger than 10MB #2470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 8, 2016 13:27
Old implementation dropped messages larger than 10MB (hard coded), to protect against memory DoS. However, in some cases the transaction was still recorded, but the parsing of the headers was incomplete. This makes the support for large messages explicit, by adding a mode to the parser that "sees" the segments without storing them.
* It used to be hardcoded to 10 MB * Added a system test for the case of messages larger than max_message_size
tsg
force-pushed
the
packetbeat_large_messages
branch
from
c2cc2d3 to
e2754c0
Compare
|
Ready for reviews. Also, cleaned up history (I prefer 3 individual commits to separate the parts that can be backported to 1.3). |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old implementation dropped messages larger than 10MB (hard coded),
to protect against memory DoS. However, in some cases the transaction
was still recorded, but the parsing of the headers was incomplete.
This makes the support for large messages explicit, by adding a mode
to the parser that "sees" the segments without storing them.
It also makes the HTTP
max_message_sizeconfigurable (no longer hard coded) and fixes an issues in master only were the body was included if the Content-Type header was missing.