Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding threads_cached,threads_created,threads_connected,threads_running to mysql module exports. #2484

Merged
merged 9 commits into from
Sep 9, 2016

Conversation

claygorman
Copy link
Contributor

@elasticsearch-release
Copy link

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run.

1 similar comment
@elasticsearch-release
Copy link

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run.

@karmi
Copy link

karmi commented Sep 7, 2016

Hi @claygorman, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

@claygorman
Copy link
Contributor Author

Hey @karmi, sorry about that! I have added the other email. I hope that does it?

Thanks!

@ruflin
Copy link
Member

ruflin commented Sep 8, 2016

@claygorman Thanks a lot for the PR. CLA looks good now. A few more things that need to be done:

This should fix the CI issue. Let me know if you need some more details.

@claygorman
Copy link
Contributor Author

claygorman commented Sep 8, 2016

On the CHANGELOG.asciidoc do I add my changes to line 9 or do I add them on line 91?

Thank you for your guidance.

@ruflin
Copy link
Member

ruflin commented Sep 8, 2016

You need to run make collect inside the metricbeat directory. For the CHANGELOG, line 91 sounds about right.

Probably you have to rebase on top of master as your branch now has a merge conflict.

@claygorman
Copy link
Contributor Author

Ok I believe I resolved the conflict. Please let me know if it looks ok.

Thanks

@andrewkroh
Copy link
Member

Please let me know if it looks ok.

No, it doesn't look correct since the changeset includes a bunch of other people's commits.

@claygorman
Copy link
Contributor Author

claygorman commented Sep 8, 2016

Ok... I think i rebased properly this time?

@andrewkroh
Copy link
Member

@claygorman Yeah, it looks like you fixed it :)

jenkins, test it

@ruflin
Copy link
Member

ruflin commented Sep 9, 2016

jenkins, test it

@ruflin
Copy link
Member

ruflin commented Sep 9, 2016

jenkins, retest it

@ruflin ruflin merged commit f234d75 into elastic:master Sep 9, 2016
@ruflin
Copy link
Member

ruflin commented Sep 9, 2016

@claygorman Merged. Thanks a lot for the contribution. It should be available in the next hours in the snapshot builds: https://beats-nightlies.s3.amazonaws.com/index.html?prefix=filebeat/

@claygorman
Copy link
Contributor Author

Thanks!

@claygorman
Copy link
Contributor Author

I noticed in https://beats-nightlies.s3.amazonaws.com/index.html?prefix=metricbeat/ the last file modified date was 2016-09-07T10:06:33.000Z and it is currently 2016-09-09T16:59:44.781Z.

Seems like snapshot hasn't been updated in 2 days (I assume its at ~10:00 every day)?

@andrewkroh
Copy link
Member

It's fixed now. New snapshots are published.

@claygorman
Copy link
Contributor Author

awesome you guys have been very helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants