Update k8s manifests to use proper roles' scope for leaderelection #24958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chrismark <chrismarkou92@gmail.com>
botelastic
bot
added
the
needs_team
|
Pinging @elastic/integrations (Team:Integrations) |
botelastic
bot
removed
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Trends 🧪❕ Flaky test reportNo test was executed to be analysed. |
Signed-off-by: chrismark <chrismarkou92@gmail.com>
Signed-off-by: chrismark <chrismarkou92@gmail.com>
jsoriano
reviewed
Apr 7, 2021
| - coordination.k8s.io | ||
| resources: | ||
| - leases | ||
| verbs: ["get", "create", "update"] |
There was a problem hiding this comment.
Ok, I see now your comment in #24913 (comment) 👍
jsoriano
approved these changes
Apr 7, 2021
ChrsMark
added a commit
to ChrsMark/beats
that referenced
this pull request
Apr 8, 2021
…lastic#24958) (cherry picked from commit 531bf81)
ChrsMark
added a commit
that referenced
this pull request
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates the roles required for using the leaderelection feature with
leaseObjects as lockObjects.Why is it important?
To improve the access/privileges we use for leaderelection.