[7.13](backport #25778) [Filebeat] Mitigate deadlock in aws-s3 ACKHandler #25826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
mergify
bot
added
backport
conflicts
botelastic
bot
added
the
needs_team
|
This pull request doesn't have a |
6 tasks
* Rename ftest to conventional testdata * Add missing encoder reader error check * Use time.Duration to represent durations in code * Mitigate deadlock in aws-s3 This is a small fix to stop the SQS keep-alive routing from returning when no error occurs while updating the visibility timeout. I also made the error chan buffered (size 1) to allow the ACKHandler to unblock even if the channel receiver routine has exited. There are still problems with the channel handling that need fixed, but IMO this should correct the most common cause. Relates #25750 (cherry picked from commit f0432df)
andrewkroh
force-pushed
the
mergify/bp/7.13/pr-25778
branch
from
a5457d1 to
9d8bb81
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #25778 done by Mergify.
Cherry-pick of f0432df has failed:
To fix up this pull request, you can check it out locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/