Fix CI pipeline #26013
Merged
Fix CI pipeline #26013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/agent (Team:Agent) |
botelastic
bot
added
needs_team
❕ Build Aborted
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Test errors
Expand to view the tests failures
|
botelastic
bot
added
the
Team:Automation
urso
commented
May 31, 2021
| cmd(label: "make notice", script: "make notice") | ||
| cmd(label: "make check-go", script: "make check-go") | ||
| cmd(label: "Check for changes", script: "make check-no-changes") |
There was a problem hiding this comment.
Update order to match make check. The make notice command can download dependencies, which results in go.sum being updated. The make check-go seems to clean the go.sum again. Depending on order of make notice and make check-go the lint checks are currently not satisfiable without requiring a fixed order. make check-go just runs go mod tidy, which seems to clean up the 'polution' from make notice.
urso
commented
May 31, 2021
| @@ -110,6 +110,7 @@ check-go: | |||
| ## ccheck-no-changes : Check there is no local changes. | |||
| .PHONY: check-no-changes | |||
| check-no-changes: | |||
| @go mod tidy | |||
There was a problem hiding this comment.
Per Beats lint runs make check; make update; make check-no-changes. The make update call touches go.sum when indirectly calling make notice. Try to be more aggressive before checking and clean up intermediary updates to go.sum before checking via git diff.
|
The linting part seems to pass, let's re-run the tests |
|
/test |
cachedout
approved these changes
Jun 1, 2021
kuisathaverat
approved these changes
Jun 1, 2021
Co-authored-by: cachedout <mike.place@elastic.co>
mergify bot
pushed a commit
that referenced
this pull request
Jun 1, 2021
Try to fix lint step in master and PRs targeting master. Co-authored-by: cachedout <mike.place@elastic.co> (cherry picked from commit c69dfb3)
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
urso
pushed a commit
that referenced
this pull request
Jun 1, 2021
Try to fix lint step in master and PRs targeting master. Co-authored-by: cachedout <mike.place@elastic.co> (cherry picked from commit c69dfb3) Co-authored-by: Steffen Siering <steffen.siering@elastic.co>
jsoriano
reviewed
Jun 10, 2021
| @@ -110,6 +110,7 @@ check-go: | |||
| ## ccheck-no-changes : Check there is no local changes. | |||
| .PHONY: check-no-changes | |||
| check-no-changes: | |||
| @go mod tidy | |||
There was a problem hiding this comment.
If we run go mod tidy here we need to run also go mod download to be consistent with make notice. I have opened a PR for this: #26241
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add missing updates from
make update.Why is it important?
Try to fix lint step in master and PRs targeting master.