Mark redis/LS port settings as deprecated #2620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urso
added
docs
review
v5.0.0-beta1
needs_backport
|
Deprecations should be marked as noted here: https://github.com/elastic/docs#additions-and-deprecations |
ruflin
reviewed
Oct 4, 2016
| @@ -447,7 +447,7 @@ batches have been written. Pipelining is disabled if a values of 0 is | |||
| configured. The default value is 0. | |||
|
|
|||
| [[port]] | |||
| ===== port | |||
There was a problem hiding this comment.
Can you use the deprecated[] ascii shortcut here?
|
I'd also add an explicit Changelog entry. |
urso
force-pushed
the
doc/deprecate-ports
branch
from
e1b06f4
to
d476efc
Compare
ruflin
reviewed
Oct 4, 2016
| @@ -69,6 +69,7 @@ https://github.com/elastic/beats/compare/v5.0.0-beta1...master[Check the HEAD di | |||
| ==== Deprecated | |||
|
|
|||
| *Affecting all Beats* | |||
| - Setting `ports` has been deprecated in redis and logstash outputs. {pull}2620[2620] | |||
There was a problem hiding this comment.
This should be port and not ports?
urso
force-pushed
the
doc/deprecate-ports
branch
from
d476efc
to
02aebe5
Compare
|
LGTM |
dedemorton
pushed a commit
to dedemorton/beats
that referenced
this pull request
Oct 5, 2016
dedemorton
removed
the
needs_backport
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.