Add batch_read_size config to Winlogbeat #2641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Sep 26, 2016
This configuration option allows users to control the number of event log records that are read, processed, and published in its event loop. Backport of elastic#2641
This configuration option allows users to control the number of event log records that are read, processed, and published in its event loop.
andrewkroh
force-pushed
the
feature/wlb-batch-read-size
branch
from
51f870b
to
0fb5ce7
Compare
ruflin
reviewed
Oct 2, 2016
| @@ -218,7 +219,7 @@ func reportDrop(reason interface{}) { | |||
| // newWinEventLog creates and returns a new EventLog for reading event logs | |||
| // using the Windows Event Log. | |||
| func newWinEventLog(options map[string]interface{}) (EventLog, error) { | |||
| var c winEventLogConfig | |||
| c := winEventLogConfig{BatchReadSize: defaultBatchReadSize} | |||
There was a problem hiding this comment.
The more "ucfg" like approach here would be probably to introduce a defaultConfig and set detaulBatchReadSize there?
|
LGTM |
ruflin
pushed a commit
that referenced
this pull request
Oct 3, 2016
This configuration option allows users to control the number of event log records that are read, processed, and published in its event loop. * Update changelog. Backport of #2641
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
This configuration option allows users to control the number of event log records that are read, processed, and published in its event loop. * Update changelog. Backport of elastic#2641
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This configuration option allows users to control the number of event log records that are read, processed, and published in its event loop.