Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.13](backport #26411) Do not close filestream harvester if an unexpected error is returned when close.on_state_change.* is enabled #26477

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 24, 2021

This is an automatic backport of pull request #26411 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

…when close.on_state_change.* is enabled (#26411)

## What does this PR do?

This PR returns early if `close.on_state_change.removed` is enabled and the opened file no longer exists. Otherwise, it logs an error message and keeps the reader running.

## Why is it important?

Previously, a message has been logged on error level and the reader has been stopped if the `Stat` call returned an error. However, it was not correct because if `close.on_state_change.renamed` was enabled the reader would have been closed if the file had been removed. Now the reader is not stopped.

(cherry picked from commit 1106449)
@mergify mergify bot added the backport label Jun 24, 2021
@mergify mergify bot assigned kvch Jun 24, 2021
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 24, 2021
@botelastic
Copy link

botelastic bot commented Jun 24, 2021

This pull request doesn't have a Team:<team> label.

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #26477 opened

  • Start Time: 2021-06-24T14:01:24.264+0000

  • Duration: 53 min 19 sec

  • Commit: 5be7e71

Test stats 🧪

Test Results
Failed 0
Passed 13738
Skipped 2299
Total 16037

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 13738
Skipped 2299
Total 16037

@kvch kvch merged commit 0469aff into 7.13 Jun 24, 2021
@mergify mergify bot deleted the mergify/bp/7.13/pr-26411 branch June 24, 2021 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants