Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #26412 to 7.x: [Metricbeat] Change Account ID to Project ID in gcp.billing module #26505

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Cherry-pick #26412 to 7.x: [Metricbeat] Change Account ID to Project ID in gcp.billing module #26505

merged 1 commit into from
Jun 28, 2021

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Jun 25, 2021

Cherry-pick of PR #26412 to 7.x branch. Original message:

What does this PR do?

Currently the GCP Project ID is being ingested as cloud.account.id instead of cloud.project.id. This PR fixes that.

Why is it important?

See above

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 25, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 25, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 25, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Started by user kaiyan-sheng

  • Start Time: 2021-06-28T13:28:47.812+0000

  • Duration: 159 min 10 sec

  • Commit: ed1a93b

Test stats 🧪

Test Results
Failed 0
Passed 1969
Skipped 192
Total 2161

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 1969
Skipped 192
Total 2161

@kaiyan-sheng kaiyan-sheng merged commit bedc535 into elastic:7.x Jun 28, 2021
@kaiyan-sheng kaiyan-sheng deleted the backport_26412_7.x branch June 28, 2021 16:32
@zube zube bot removed the [zube]: Done label Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants