-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: pass BEAT_VERSION when running E2E tests (backport #26291) #26889
Conversation
(cherry picked from commit ea84a3b)
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
Hi! We're labeling this issue as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this backport is updated... please close if this is not needed anymore.
@@ -524,6 +524,7 @@ def e2e(Map args = [:]) { | |||
def goVersionForE2E = readFile('.go-version').trim() | |||
withEnv(["GO_VERSION=${goVersionForE2E}", | |||
"BEATS_LOCAL_PATH=${env.WORKSPACE}/${env.BASE_DIR}", | |||
"BEAT_VERSION=${env.VERSION}-SNAPSHOT", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Umm, triggerE2ETests
also appends -SNAPSHOT
, do we have the risk of appending it twice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, there is no risk, as we set that version to be used as input parameter of the downstream job for the e2e tests
Well, this should be applied in 7.14 for consistency as it was applied to 7.13, 7.15 and 7.x. |
Hi! We're labeling this issue as |
@mdelapenya can this be closed? |
Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
@jsoriano if you agree, I'm merging this one |
…) (elastic#26889) * chore: pass BEAT_VERSION when running E2E tests (elastic#26291) (cherry picked from commit b35a1bf) * fix: proper param type Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co> Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com> Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
This is an automatic backport of pull request #26291 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/