Backport: Set strings to be keywords by default (#2688) #2696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a dynamic mapping to all our template files to set strings to be keywords by default. Previously we were using the default of `text` and only switching to `keyword` when configured in `fields.yml`. This reverses the logic and sets mappings to `text` only when requested in `fields.yml`. The goal is to make upgrading the mapping template less painful. In the Beats we have so far, unexpected fields are better of as keywords.
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
Backport: Set strings to be keywords by default (elastic#2688)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #2688. Original message:
This adds a dynamic mapping to all our template files to set strings to be
keywords by default.
Previously we were using the default of
textand only switching tokeywordwhen configured in
fields.yml. This reverses the logic and sets mappings totextonly when requested infields.yml.The goal is to make upgrading the mapping template less painful. In the Beats
we have so far, unexpected fields are better of as keywords.