Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transform json.Number values from http_endpoint #27480

Merged
merged 2 commits into from
Aug 19, 2021
Merged

Transform json.Number values from http_endpoint #27480

merged 2 commits into from
Aug 19, 2021

Conversation

adriansr
Copy link
Contributor

What does this PR do?

This adds a necessary transform to the output of http_endpoint so that numeric values are encoded as such instead of as a string.

Why is it important?

After a refactor of the input, numeric values in the original input were being encoded as a string in the output event.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Fixes #27382

@adriansr
Transform json.Number values from http_endpoint
dffa1f0 
This adds a necessary transform to the output of http_endpoint
so that numeric values are encoded as such instead of as a
string.

Fixes elastic#27382
@adriansr adriansr added bug review Team:Security-External Integrations backport-v7.14.0 Automated backport with mergify backport-v7.15.0 Automated backport with mergify labels Aug 18, 2021
@adriansr adriansr requested a review from andrewkroh August 18, 2021 20:46
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 18, 2021
@adriansr adriansr added the backport-v7.16.0 Automated backport with mergify label Aug 18, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 18, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-18T20:48:37.452+0000

  • Duration: 90 min 8 sec

  • Commit: d5a9bed

Test stats 🧪

Test Results
Failed 0
Passed 8142
Skipped 1201
Total 9343

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 8142
Skipped 1201
Total 9343

@adriansr adriansr merged commit 704007d into elastic:master Aug 19, 2021
mergify bot pushed a commit that referenced this pull request Aug 19, 2021
@adriansr
Transform json.Number values from http_endpoint (#27480)
0a34575 
This adds a necessary transform to the output of http_endpoint
so that numeric values are encoded as such instead of as a
string.

Fixes #27382

(cherry picked from commit 704007d)
@mergify mergify bot mentioned this pull request Aug 19, 2021
Merged
mergify bot pushed a commit that referenced this pull request Aug 19, 2021
@adriansr
Transform json.Number values from http_endpoint (#27480)
a4d53ac 
This adds a necessary transform to the output of http_endpoint
so that numeric values are encoded as such instead of as a
string.

Fixes #27382

(cherry picked from commit 704007d)
@mergify mergify bot mentioned this pull request Aug 19, 2021
Merged
mergify bot pushed a commit that referenced this pull request Aug 19, 2021
@adriansr
Transform json.Number values from http_endpoint (#27480)
cae4f64 
This adds a necessary transform to the output of http_endpoint
so that numeric values are encoded as such instead of as a
string.

Fixes #27382

(cherry picked from commit 704007d)
@mergify mergify bot mentioned this pull request Aug 19, 2021
Merged
adriansr added a commit that referenced this pull request Aug 19, 2021
@mergify @adriansr
Transform json.Number values from http_endpoint (#27480) (#27488)
6589680 
This adds a necessary transform to the output of http_endpoint
so that numeric values are encoded as such instead of as a
string.

Fixes #27382

(cherry picked from commit 704007d)

Co-authored-by: Adrian Serrano <adrisr83@gmail.com>
adriansr added a commit that referenced this pull request Aug 19, 2021
@mergify @adriansr
Transform json.Number values from http_endpoint (#27480) (#27490)
c30b7af 
This adds a necessary transform to the output of http_endpoint
so that numeric values are encoded as such instead of as a
string.

Fixes #27382

(cherry picked from commit 704007d)

Co-authored-by: Adrian Serrano <adrisr83@gmail.com>
adriansr added a commit that referenced this pull request Aug 19, 2021
@mergify @adriansr
Transform json.Number values from http_endpoint (#27480) (#27489)
5dfcea0 
This adds a necessary transform to the output of http_endpoint
so that numeric values are encoded as such instead of as a
string.

Fixes #27382

(cherry picked from commit 704007d)

Co-authored-by: Adrian Serrano <adrisr83@gmail.com>
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
@adriansr
Transform json.Number values from http_endpoint (elastic#27480)
fda290d 
This adds a necessary transform to the output of http_endpoint
so that numeric values are encoded as such instead of as a
string.

Fixes elastic#27382
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees
No one assigned
Labels
backport-v7.14.0 Automated backport with mergify backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify bug review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

http_endpoint: 7.14.0 breaks backwards compatibility by encoding numbers as strings
3 participants
@adriansr @elasticmachine @andrewkroh