-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filebeat] Integration tests in CI for AWS-S3 input #27491
Merged
aspacca
merged 10 commits into
elastic:master
from
aspacca:Filebeat-Integration-tests-in-CI-for-AWS-S3-input
Sep 6, 2021
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
8cd6025
[Filebeat] Integration tests in CI for AWS-S3 input
68c009f
fix directory
289c85f
Bump terraform version
v1v dab3a44
Fail terraform apply if any errors after retry
v1v dc13f91
Merge branch 'master' into Filebeat-Integration-tests-in-CI-for-AWS-S…
fc67dab
Merge branch 'master' into Filebeat-Integration-tests-in-CI-for-AWS-S…
c1859de
rely on dirs
f27d69e
Update Jenkinsfile
aspacca 5348c48
Configure aws credentials on a PR basis if 'aws' has been assigned
v1v a2f2177
use t2.micro
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,7 +22,7 @@ pipeline { | |
RUNBLD_DISABLE_NOTIFICATIONS = 'true' | ||
SLACK_CHANNEL = "#beats-build" | ||
SNAPSHOT = 'true' | ||
TERRAFORM_VERSION = "0.12.30" | ||
TERRAFORM_VERSION = "0.13.7" | ||
XPACK_MODULE_PATTERN = '^x-pack\\/[a-z0-9]+beat\\/module\\/([^\\/]+)\\/.*' | ||
} | ||
options { | ||
|
@@ -832,8 +832,10 @@ def withCloudTestEnv(Closure body) { | |
def maskedVars = [] | ||
def testTags = "${env.TEST_TAGS}" | ||
|
||
// AWS | ||
if (params.allCloudTests || params.awsCloudTests) { | ||
// Allow AWS credentials when the build was configured to do so with: | ||
// - the cloudtests build parameters | ||
// - the aws github label | ||
if (params.allCloudTests || params.awsCloudTests || matchesPrLabel(label: 'aws')) { | ||
testTags = "${testTags},aws" | ||
def aws = getVaultSecret(secret: "${AWS_ACCOUNT_SECRET}").data | ||
if (!aws.containsKey('access_key')) { | ||
|
@@ -885,6 +887,7 @@ def startCloudTestEnv(Map args = [:]) { | |
// If it failed then cleanup without failing the build | ||
sh(label: 'Terraform Cleanup', script: ".ci/scripts/terraform-cleanup.sh ${folder}", returnStatus: true) | ||
} | ||
error('startCloudTestEnv: terraform apply failed.') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Enforce the error is reported after the catch closure |
||
} finally { | ||
// Archive terraform states in case manual cleanup is needed. | ||
archiveArtifacts(allowEmptyArchive: true, artifacts: '**/terraform.tfstate') | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should help to configure the AWS credentials when the
aws
github label was assigned to the Pull Request as explained in #27491 (comment)