Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use v8format=true for Kibana health check #28185

Merged

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Sep 29, 2021

What does this PR do?

The default format of the /api/status output is changing so update our
check. We'll use v8format=true so that checks against older images will
pass too.

Relates elastic/kibana#110830

Why is it important?

Allows tests to execute under newer Kibana versions.

Logs

Old format:

{
  "name": "fd1c727b700f",
  "uuid": "903de1b1-9d8b-4db6-9932-00c8ccd26bbc",
  "version": {
    "number": "8.0.0",
    "build_hash": "b1f38f459f9b5f259e9f99ad9d02f67e90505830",
    "build_number": 45390,
    "build_snapshot": true
  },
  "status": {
    "overall": {
      "since": "2021-09-29T13:46:24.658Z",
      "state": "yellow",
      "title": "Yellow",
      "nickname": "I'll be back",
      "icon": "warning",
      "uiColor": "warning"
    },

New format:

{
  "name": "7d1500db67ba",
  "uuid": "d55b6d6c-0b87-4364-915f-cc92af242a67",
  "version": {
    "number": "8.0.0",
    "build_hash": "c647929eeb7881bf3f80dcc1d4dab0027650666e",
    "build_number": 46558,
    "build_snapshot": true
  },
  "status": {
    "overall": {
      "level": "available",
      "summary": "All services are available"
    },
    "core": {
      "elasticsearch": {
        "level": "available",
        "summary": "Elasticsearch is available",
        "meta": {
          "warningNodes": [],
          "incompatibleNodes": []
        }
      },
      "savedObjects": {
        "level": "available",
        "summary": "SavedObjects service has completed migrations and is available",
        "meta": {
          "migratedIndices": {
            "migrated": 0,
            "skipped": 0,
            "patched": 2
          }
        }
      }
    },

The default format of the /api/status output is changing so update our
check. We'll use v8format=true so that checks against older images will
pass too.

Relates elastic/kibana#110830
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 29, 2021
@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2021

This pull request does not have a backport label. Could you fix it @andrewkroh? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Sep 29, 2021
@andrewkroh andrewkroh added backport-v7.16.0 Automated backport with mergify Team:Automation Label for the Observability productivity team and removed backport-skip Skip notification from the automated backport with mergify labels Sep 29, 2021
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 29, 2021
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming CI goes green.

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-29T13:59:42.413+0000

  • Duration: 157 min 9 sec

  • Commit: 1d4d7bf

Test stats 🧪

Test Results
Failed 0
Passed 54147
Skipped 5328
Total 59475

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

@andrewkroh andrewkroh merged commit f595b05 into elastic:master Sep 29, 2021
mergify bot pushed a commit that referenced this pull request Sep 29, 2021
The default format of the /api/status output is changing so update our
check. We'll use v8format=true so that checks against older images will
pass too.

Relates elastic/kibana#110830

(cherry picked from commit f595b05)
andrewkroh added a commit that referenced this pull request Sep 29, 2021
The default format of the /api/status output is changing so update our
check. We'll use v8format=true so that checks against older images will
pass too.

Relates elastic/kibana#110830

(cherry picked from commit f595b05)

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
The default format of the /api/status output is changing so update our
check. We'll use v8format=true so that checks against older images will
pass too.

Relates elastic/kibana#110830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.16.0 Automated backport with mergify Team:Automation Label for the Observability productivity team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants