[Metricbeat] gcp: fix integration tests #28364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endorama
added
Team:Integrations
|
Pinging @elastic/integrations (Team:Integrations) |
botelastic
bot
added
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
kaiyan-sheng
approved these changes
Oct 12, 2021
|
This pull request is now in conflicts. Could you fix it? 🙏 |
GCP SDK require GCP_* based variable for a correct initialization. In our tests for GCP module we require GCP_PROJECT_ID and GCP_CREDENTIALS_FILE_PATH to be set.
GCP Billing tests require access to the billing account. This access is restricted and will not be granted to everyone working on beats. In order to be able to run integration tests without a always-failing gcp.billing tests, adding this tag allow to skip billing tests unless specified.
6 tasks
mergify bot
pushed a commit
that referenced
this pull request
Oct 13, 2021
(cherry picked from commit e8066e9) # Conflicts: # x-pack/metricbeat/module/gcp/DEVELOPMENT.md # x-pack/metricbeat/module/gcp/billing/billing_integration_test.go
endorama
added a commit
that referenced
this pull request
Oct 13, 2021
endorama
added a commit
that referenced
this pull request
Oct 13, 2021
(cherry picked from commit e8066e9)
endorama
added a commit
that referenced
this pull request
Oct 14, 2021
(cherry picked from commit e8066e9)
endorama
added a commit
that referenced
this pull request
Oct 14, 2021
Co-authored-by: endorama <526307+endorama@users.noreply.github.com>
Icedroid
pushed a commit
to Icedroid/beats
that referenced
this pull request
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Provide fixes for
gcpmetricbeat module integration tests.Why is it important?
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
TEST_TAGS=gcp MODULE=gcp mage goIntegTestRelated issues
Use cases
Screenshots
Logs