Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libbeat] Remove common.Float #28376

Merged
merged 1 commit into from
Oct 13, 2021
Merged

[libbeat] Remove common.Float #28376

merged 1 commit into from
Oct 13, 2021

Conversation

andrewkroh
Copy link
Member

What does this PR do?

Remove deprecated common.Float from 8.0.

#28280 (comment)

Why is it important?

Removes unused code.

Checklist

  • My code follows the style guidelines of this project
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@andrewkroh andrewkroh added libbeat Team:Security-External Integrations backport-skip Skip notification from the automated backport with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Oct 13, 2021
@andrewkroh andrewkroh requested a review from a team October 13, 2021 00:24
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 13, 2021
@andrewkroh
Remove common.Float
b749106 
Remove deprecated common.Float from 8.0.

Relates elastic#28279
Relates elastic#28280
@andrewkroh andrewkroh force-pushed the bugfix/libbeat/remove-common-float branch from 1a9fd83 to b749106 Compare October 13, 2021 00:24
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-13T00:25:28.522+0000

  • Duration: 146 min 4 sec

  • Commit: b749106

Test stats 🧪

Test Results
Failed 0
Passed 53757
Skipped 5346
Total 59103

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

@andrewkroh andrewkroh merged commit 1e5a29d into elastic:master Oct 13, 2021
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
@andrewkroh
Remove common.Float (elastic#28376)
e45cf08 
Remove deprecated common.Float from 8.0.

Relates elastic#28279
Relates elastic#28280
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

Assignees
No one assigned
Labels
backport-skip Skip notification from the automated backport with mergify libbeat Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewkroh @elasticmachine @efd6