Move tail_files to prospector level #2932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
force-pushed
the
tail_files-prospector
branch
from
107f9dc to
a01eb23
Compare
|
This PR applies tail_files on every restart to every new file discovered since last run. I'd rather see tail_files only being effective if no registry exists (or is empty on startup). |
ruflin
force-pushed
the
tail_files-prospector
branch
from
a01eb23 to
0417234
Compare
tail_files is now only applied on the first run and after that ignored. Also the state for all files falling under tail_files and not having a state, a state will directly be written. * Implement tail_files by setting ignore_older to 1ns for the first run * Fix typo in stats variable names Closes elastic#2613 and elastic#2788
ruflin
force-pushed
the
tail_files-prospector
branch
from
0417234 to
fc63764
Compare
urso
reviewed
Nov 4, 2016
| // Disable tail_files after the first run | ||
| p.config.TailFiles = false | ||
| }() | ||
| } |
There was a problem hiding this comment.
how about:
if p.config.TailFiles {
defer func(old time.Duration) {
p.config.IgnoreOlder = old
}(p.config.IgnoreOlder)
p.config.TailFiles = false // disable tail_files in future calls
p.config.IgnoreOlder = 1 * time.Nanosecond
}
There was a problem hiding this comment.
Should also work. The advantage of the first version is, that in case TailFiles is also used somewhere inside the first scan (which is not the case), it would still work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tail_files is now only applied on the first run and after that ignored. Also the state for all files falling under tail_files and not having a state, a state will directly be written.
Closes #2613 and #2788