Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metricbeat MongoDB module improvements #2999

Merged
merged 2 commits into from
Nov 15, 2016
Merged

Conversation

tsg
Copy link
Contributor

@tsg tsg commented Nov 14, 2016

Planning the following TODOs:

Several fields are not reported when the storage engine is set to
wiredTiger, so marking them as optional. Fixes elastic#2990.
@tsg tsg added in progress Pull request is currently in progress. review labels Nov 14, 2016
Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@@ -31,7 +31,7 @@ var schema = s.Schema{
"ms": c.Int("last_ms"),
},
"last_finished": c.Time("last_finished"),
}),
}, c.DictOptional),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@tsg
Copy link
Contributor Author

tsg commented Nov 15, 2016

I'm going to do the dashboards in a separate PR.

@tsg tsg removed the in progress Pull request is currently in progress. label Nov 15, 2016
Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -27,8 +27,8 @@ func TestFetch(t *testing.T) {
available := event["connections"].(common.MapStr)["available"].(int64)
assert.True(t, available > 0)

commits := event["journaling"].(common.MapStr)["commits"].(int64)
assert.True(t, commits >= 0)
page_faults := event["extra_info"].(common.MapStr)["page_faults"].(int64)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable name is quite python-like ;-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed :)

* Favored a few actionable metrics.
* Use mongo 3.4 in our integration tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants