[winlogbeat] Clean up rune handling #32198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc-gr
added
enhancement
Winlogbeat
Team:Security-External Integrations
backport-v8.3.0
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
botelastic
bot
added
needs_team
adriansr
approved these changes
Jul 5, 2022
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
|
@marc-gr test failures seem to be real, please have a look. |
|
/test |
efd6
approved these changes
Jul 6, 2022
|
/test |
1 similar comment
|
/test |
adriansr
approved these changes
Jul 12, 2022
andrewkroh
approved these changes
Jul 13, 2022
mergify bot
pushed a commit
that referenced
this pull request
Jul 14, 2022
* Take into account RuneErrors when decoding XML codes * Add more unit tests * Parse multibyte utf8 encodings at the end of backing array (cherry picked from commit 157c327)
mergify bot
pushed a commit
that referenced
this pull request
Jul 14, 2022
* Take into account RuneErrors when decoding XML codes * Add more unit tests * Parse multibyte utf8 encodings at the end of backing array (cherry picked from commit 157c327)
marc-gr
added a commit
that referenced
this pull request
Jul 14, 2022
* Take into account RuneErrors when decoding XML codes * Add more unit tests * Parse multibyte utf8 encodings at the end of backing array (cherry picked from commit 157c327) Co-authored-by: Marc Guasch <marc-gr@users.noreply.github.com>
marc-gr
added a commit
that referenced
this pull request
Jul 18, 2022
* Take into account RuneErrors when decoding XML codes * Add more unit tests * Parse multibyte utf8 encodings at the end of backing array (cherry picked from commit 157c327) Co-authored-by: Marc Guasch <marc-gr@users.noreply.github.com>
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
* Take into account RuneErrors when decoding XML codes * Add more unit tests * Parse multibyte utf8 encodings at the end of backing array (cherry picked from commit 2f5a5e1) Co-authored-by: Marc Guasch <marc-gr@users.noreply.github.com>
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
* Take into account RuneErrors when decoding XML codes * Add more unit tests * Parse multibyte utf8 encodings at the end of backing array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Why is it important?
Checklist
- [] I have commented my code, particularly in hard-to-understand areas- [] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.